Feature / Font size selector on PDF export #1612
Conversation
There was a problem hiding this comment.
@chelsouse Nice work!! Take a look at the comments that i made! Let me now if you have some doubts!
|
Hello @RodriSanchez1 I've implemented the requested changes. Please let me know, if it needs any futher changes. |
There was a problem hiding this comment.
@chelsouse Nice workk! I made a few changes, check it out!
I want to give you a little advice, in your future commits try to implement atomic commits. This way, your work will be more detailed. An also always add a PR description!
See:
What's an atomic git commit?
Working with atomic git commits means your commits are of the smallest possible size. Each commit does one, and only one simple thing, that can be summed up in a simple sentence.
The amount of code change doesn't matter. It can be a letter or it can be a hundred thousand lines, but you should be able to describe the change with one simple short sentence.
Hope you want continue contributing on Cboard!
Regards, Rodri!
|
Hello @RodriSanchez1 Thanks for your help and advice on atomic commits! It's my first PR, and I'll definitely keep your suggestions in mind. Appreciate the guidance! |
PR for issue #1575