Integrate google photos #964
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is necesary to Save step too
This should be implemented with hunk and middlewares.
this prevent the upload of the photo selected on the first step and return the user the exact view and data after authorize cboard to use google photos during a editing of multiple tiles.
pending to resolve package-lock.json
tomivm
requested review from
shayc,
martinbedouret,
sylvansson and
RodriSanchez1
martinbedouret
requested changes
Jul 6, 2021
src/components/Board/GooglePhotosSearch/GooglePhotosFilter/googlePhotosFilter.component.js
Outdated
Show resolved
Hide resolved
martinbedouret
requested changes
Jul 6, 2021
src/components/Board/GooglePhotosSearch/GooglePhotosButton/GooglePhotosConnect.Button.js
Show resolved
Hide resolved
src/components/Board/GooglePhotosSearch/GooglePhotosButton/GooglePhotosConnect.Button.js
Show resolved
Hide resolved
The requested changes on Google Photos button are not ready on this commit
…tos' into feature/integrate-with-googlePhotos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds the capability to upload photos from a Google Photos account.
To finally select a photo and store it on the board is necessary to run 'cboard-api' on the 'feature/support-for-google-photos' branch.
Is my first time with a PR of this size. Please share your opinions. Especially with respect about files names and folders structure.
You can see the button to connect and add content on 'TileEditor'