Add tests for string markers #14
Conversation
|
Can you rebase please? I assume this fixes #10, correct? |
|
It does, but listen, can we go one by one? As I said, so many PRs add complexity for me. I don't want to keep three or four branches at the same time. Which one would you like to do first? Should we go for this one now? |
|
Yes, let's do this one now. |
* upstream/main: Add Autoformatting with Blue style (cbrnr#12)
| ### ✨ Added | ||
| - Add tests for string markers from issue xdf-modules/libxdf#19 (([#13](https://github.com/cbrnr/XDF.jl/pull/13) by [Alberto Barradas](https://github.com/abcsds))) |
There was a problem hiding this comment.
I think we should be more specific here. You fixed an issue with string streams consisting of multiple channels, right? It would be more helpful to explicitly mention this here instead of linking to an issue. Also, I think this change should then go into the "Fixed" section, WDYT?
There was a problem hiding this comment.
What did you mention is the template to follow? I can't find the emoji for the fixed section. I thought you mentioned a repo from xdf-modules, but their changelogs don't have emojis. I can't find the pr where it was mentioned. I thought it was #11.
There was a problem hiding this comment.
Would you be up for adding this file to https://github.com/xdf-modules/example-files/ instead? That way, other projects could also use this test file.
There was a problem hiding this comment.
Adds tests for file from xdf-modules/libxdf#19 Small EEG xdf with two channel string markers. We do not present the issue. Tests pass.