fix: enterKeyHint and inputMode missing from inputBaseComponentProps #215
Conversation
illusionalsagacity
force-pushed
the
fix-missing-props-inputBaseComponentProps
branch
from
cb99494 to
a7fcc42
Compare
| type inputBaseComponentProps = { | ||
| ...CommonProps.clickableProps, | ||
| name?: string, | ||
| step?: int, | ||
| min?: int, | ||
| max?: int, | ||
| @as("type") type_?: string, | ||
| @as("disableunderline") disableUnderline?: string, |
There was a problem hiding this comment.
I removed disableUnderline in favor of adding it to the InputBase.props, was that wrong?
it was so that it also works with <Select />.
Also I don't know why this was type string here.
There was a problem hiding this comment.
Hm, must have been a merge issue on my end. I will address it soon
There was a problem hiding this comment.
@fhammerschmidt I've removed the offending line
|
Very appreciated, thanks! |
illusionalsagacity
force-pushed
the
fix-missing-props-inputBaseComponentProps
branch
from
a7fcc42 to
0f8fd07
Compare
|
@illusionalsagacity Is there anything else coming up from you? Otherwise I will do a release soonish. |
illusionalsagacity
deleted the
fix-missing-props-inputBaseComponentProps
branch
@fhammerschmidt I think there's some more open things we've found that I can open issues for, I'll have to go through them. Also I'm not currently blocked on these things, we've got some workarounds for the moment. Obviously I won't want to create any toil for you all making releases if that can be avoided though. |
Happy to contribute adding more of these, but figured I would start off with the two I know I need