Adds missing props to InputBase types #228
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, please spread them into the TextField props if possible. There might be an overlap though. |
@fhammerschmidt I've pushed a WIP commit that shows one way we could accomplish this, by creating more 'partial' record types and composing them more directly where they're being used |
| | @as("soft") Soft | ||
| | @as("off") Off | ||
|
|
||
| type inputBaseComponentPublicProps = { |
There was a problem hiding this comment.
IMO, this should probably be in CommonProps for inputs / textarea props
illusionalsagacity
force-pushed
the
input-base-props
branch
from
fbfa51b to
8996322
Compare
|
Apart from the conflicts and the commented-out props that got overridden (I think you can just remove them), is this ready? |
inputBaseComponentProps: minLength, wrap publicProps: maxLength, minLength, wrap resolves cca-io#224
illusionalsagacity
force-pushed
the
input-base-props
branch
from
8996322 to
57c7ee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inputBaseComponentProps: minLength, wrap
publicProps: maxLength, minLength, wrap
resolves #224