Legalization #476

hibenj · 2024-07-17T15:51:26Z

Description

Adds the following .hpp and .cpp files:

check_planarity: For a given network with a rank view, check for planarity
virtual_pi_network: stores additional PIs, which are duplicates of other pis. These are called virtual PIs and are stored with a map to their origin PI
extended_rank_view: the extended rank_view allows for a more easy modification of ranks and also adds another constructor from an array of nodes. (This might also be more error prone)
node_suplication_planarization: Constucts an H-graph (as in "Fabricatable Interconnect and
Molecular QCA Circuits") in order to duplicate nodes on a given PO order. The output is a extended_rank_view of a virtual_pi_network

Fixes # (issue)

Checklist:

The pull request only contains commits that are related to it.
I have added appropriate tests and documentation.
I have added a changelog entry.
I have created/adjusted the Python bindings for any new or updated functionality.
I have made sure that all CI jobs on GitHub pass.
The pull request introduces no new warnings and follows the project's style guidelines.

…es have to be written as indicated in the ToDo)

…ified

…heck_validity functions

…rators.

…equivalence checking inside the extended rank view.

…so a rank_view.

…p as constructor.

…on_planarization.hpp. The function has no use in any other context (so far).

Signed-off-by: GitHub Actions <[email protected]>

# Conflicts: # include/fiction/algorithms/network_transformation/buffer_removal.hpp

Drewniok · 2024-09-26T10:51:03Z

@hibenj No worries, the CI fails on Mac because you accidentally updated the submodules. You should revert those changes to fix this :)

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 51. Check the log or trigger a new build to see more.

github-actions · 2024-10-14T11:07:11Z

experiments/legalization/legalization.cpp

+        // check equivalence
+        mockturtle::equivalence_checking_stats st;
+        const auto                             cec_m = mockturtle::equivalence_checking(
+            *fiction::virtual_miter<fiction::technology_network>(benchmark_network, planarized_b), {}, &st);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

*fiction::virtual_miter<fiction::technology_network>(benchmark_network, planarized_b), {}, &st); ^

github-actions · 2024-10-14T11:07:11Z

experiments/legalization/legalization.cpp

+            fiction::clocked_layout<fiction::tile_based_layout<fiction::cartesian_layout<fiction::offset::ucoord_t>>>>;
+        auto layout = fiction::orthogonal<gate_layout>(planarized_b, {}, &stats);
+
+        fiction::gate_level_drv_params ps_d{};


warning: variable 'ps_d' of type 'fiction::gate_level_drv_params' can be declared 'const' [misc-const-correctness]

Suggested change

fiction::gate_level_drv_params ps_d{};

fiction::gate_level_drv_params const ps_d{};

github-actions · 2024-10-14T11:07:11Z

experiments/legalization/legalization.cpp

+            mockturtle::equivalence_checking_stats st_o;
+
+            const auto ce = mockturtle::equivalence_checking(*miter, {}, &st_o);
+            eq            = ce.value();


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

eq = ce.value(); ^

github-actions · 2024-10-14T11:07:11Z

experiments/legalization/legalization.cpp

+        // log results
+        wiring_reduction_exp(benchmark, benchmark_network.num_pis(), planarized_b.num_virtual_pis(),
+                             benchmark_network.num_pos(), benchmark_network.num_gates(), b.num_gates(),
+                             planarized_b.num_gates(), is_planar, cec_m.value(), eq);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

planarized_b.num_gates(), is_planar, cec_m.value(), eq); ^

github-actions · 2024-10-14T11:07:11Z

experiments/legalization/legalization.cpp

+        wiring_reduction_exp.table();
+    }
+
+    return EXIT_SUCCESS;


warning: no header providing "EXIT_SUCCESS" is directly included [misc-include-cleaner]

experiments/legalization/legalization.cpp:30:

- #include <filesystem> + #include <cstdlib> + #include <filesystem>

github-actions · 2024-10-14T11:07:13Z

include/fiction/networks/views/extended_rank_view.hpp

+     *
+     * @return Width of the widest rank in the network.
+     */
+    uint32_t width() const noexcept


warning: function 'width' should be marked [[nodiscard]] [modernize-use-nodiscard]

Suggested change

uint32_t width() const noexcept

[[nodiscard]] uint32_t width() const noexcept

github-actions · 2024-10-14T11:07:13Z

include/fiction/networks/views/extended_rank_view.hpp

+    {
+        for (auto l = 0; l < ranks.size(); ++l)
+        {
+            foreach_node_in_rank(l, std::forward<Fn>(fn));


warning: implicit conversion changes signedness: 'int' to 'uint32_t' (aka 'unsigned int') [clang-diagnostic-sign-conversion]

foreach_node_in_rank(l, std::forward<Fn>(fn)); ^

Additional context

include/fiction/utils/network_utils.hpp:274: in instantiation of function template specialization 'fiction::extended_rank_view<fiction::virtual_pi_networkfiction::technology_network>::foreach_node<(lambda at /github/workspace/include/fiction/utils/network_utils.hpp:276:9)>' requested here

ntk.foreach_node( ^

include/fiction/algorithms/physical_design/orthogonal.hpp:686: in instantiation of function template specialization 'fiction::has_high_degree_fanin_nodes<fiction::extended_rank_view<fiction::virtual_pi_networkfiction::technology_network>>' requested here

or input degree ^

experiments/legalization/legalization.cpp:128: in instantiation of function template specialization 'fiction::orthogonal<fiction::gate_level_layout<fiction::clocked_layout<fiction::tile_based_layout<fiction::cartesian_layout<>>>>, fiction::extended_rank_view<fiction::virtual_pi_networkfiction::technology_network>>' requested here

auto layout = fiction::orthogonal<gate_layout>(planarized_b, {}, &stats); ^

github-actions · 2024-10-14T11:07:13Z

include/fiction/networks/views/extended_rank_view.hpp

+    {
+        for (auto l = 0; l < ranks.size(); ++l)
+        {
+            foreach_gate_in_rank(l, std::forward<Fn>(fn));


warning: implicit conversion changes signedness: 'int' to 'uint32_t' (aka 'unsigned int') [clang-diagnostic-sign-conversion]

foreach_gate_in_rank(l, std::forward<Fn>(fn)); ^

Additional context

include/fiction/networks/virtual_pi_network.hpp:391: in instantiation of function template specialization 'fiction::extended_rank_view<fiction::virtual_pi_networkfiction::technology_network>::foreach_gate<(lambda at /github/workspace/include/fiction/networks/virtual_pi_network.hpp:393:13)>' requested here

ntk_topo.foreach_gate( ^

include/fiction/networks/virtual_pi_network.hpp:560: in instantiation of member function 'fiction::detail::delete_virtual_pis_impl<fiction::extended_rank_view<fiction::virtual_pi_networkfiction::technology_network>>::run' requested here

auto result = p.run(); ^

include/fiction/algorithms/verification/virtual_miter.hpp:23: in instantiation of function template specialization 'fiction::delete_virtual_pis<fiction::extended_rank_view<fiction::virtual_pi_networkfiction::technology_network>>' requested here

return delete_virtual_pis(network); ^

experiments/legalization/legalization.cpp:122: in instantiation of function template specialization 'fiction::virtual_miter<fiction::technology_network, mockturtle::names_viewfiction::technology_network, fiction::extended_rank_view<fiction::virtual_pi_networkfiction::technology_network>>' requested here

*fiction::virtual_miter<fiction::technology_network>(benchmark_network, planarized_b), {}, &st); ^

github-actions · 2024-10-14T11:07:14Z

include/fiction/networks/views/extended_rank_view.hpp

+    std::vector<std::vector<node>>      ranks;
+    uint32_t                            max_rank_width;
+
+    std::shared_ptr<typename mockturtle::network_events<Ntk>::add_event_type> add_event;


warning: no header providing "mockturtle::network_events" is directly included [misc-include-cleaner]

include/fiction/networks/views/extended_rank_view.hpp:8:

- #include <mockturtle/traits.hpp> + #include <mockturtle/networks/events.hpp> + #include <mockturtle/traits.hpp>

github-actions · 2024-10-14T11:07:14Z

include/fiction/networks/views/extended_rank_view.hpp

+    void insert_in_rank(const node& n)
+    {
+        auto& rank  = ranks[this->level(n)];
+        rank_pos[n] = rank.size();


warning: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'value_type' (aka 'unsigned int') [clang-diagnostic-shorten-64-to-32]

rank_pos[n] = rank.size(); ^

Additional context

include/fiction/networks/views/extended_rank_view.hpp:471: in instantiation of member function 'fiction::extended_rank_view<fiction::virtual_pi_networkfiction::technology_network>::insert_in_rank' requested here

insert_in_rank(n); ^

include/fiction/networks/views/extended_rank_view.hpp:142: in instantiation of member function 'fiction::extended_rank_view<fiction::virtual_pi_networkfiction::technology_network>::on_add' requested here

add_event = Ntk::events().register_add_event([this](auto const& n) { on_add(n); }); ^

include/fiction/algorithms/network_transformation/node_duplication_planarization.hpp:647: in instantiation of member function 'fiction::extended_rank_view<fiction::virtual_pi_networkfiction::technology_network>::extended_rank_view' requested here

return extended_rank_view(virtual_ntk, ntk_lvls_new); ^

include/fiction/algorithms/network_transformation/node_duplication_planarization.hpp:706: in instantiation of member function 'fiction::detail::node_duplication_planarization_implfiction::technology_network::run' requested here

auto result = p.run(ntk_lvls_new); ^

experiments/legalization/legalization.cpp:114: in instantiation of function template specialization 'fiction::node_duplication_planarizationfiction::technology_network' requested here

const auto planarized_b = fiction::node_duplication_planarization<fiction::technology_network>(b); ^

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 46. Check the log or trigger a new build to see more.

github-actions · 2024-10-15T13:32:10Z

experiments/legalization/legalization.cpp

+        // check equivalence
+        mockturtle::equivalence_checking_stats st;
+        const auto                             cec_m = mockturtle::equivalence_checking(
+            *fiction::virtual_miter<fiction::technology_network>(benchmark_network, planarized_b), {}, &st);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

*fiction::virtual_miter<fiction::technology_network>(benchmark_network, planarized_b), {}, &st); ^

github-actions · 2024-10-15T13:32:10Z

experiments/legalization/legalization.cpp

+            fiction::clocked_layout<fiction::tile_based_layout<fiction::cartesian_layout<fiction::offset::ucoord_t>>>>;
+        auto layout = fiction::orthogonal<gate_layout>(planarized_b, {}, &stats);
+
+        fiction::gate_level_drv_params ps_d{};


warning: variable 'ps_d' of type 'fiction::gate_level_drv_params' can be declared 'const' [misc-const-correctness]

Suggested change

fiction::gate_level_drv_params ps_d{};

fiction::gate_level_drv_params const ps_d{};

github-actions · 2024-10-15T13:32:10Z

experiments/legalization/legalization.cpp

+            mockturtle::equivalence_checking_stats st_o;
+
+            const auto ce = mockturtle::equivalence_checking(*miter, {}, &st_o);
+            eq            = ce.value();


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

eq = ce.value(); ^

github-actions · 2024-10-15T13:32:11Z

experiments/legalization/legalization.cpp

+        // log results
+        wiring_reduction_exp(benchmark, benchmark_network.num_pis(), planarized_b.num_virtual_pis(),
+                             benchmark_network.num_pos(), benchmark_network.num_gates(), b.num_gates(),
+                             planarized_b.num_gates(), is_planar, cec_m.value(), eq);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

planarized_b.num_gates(), is_planar, cec_m.value(), eq); ^

github-actions · 2024-10-15T13:32:11Z

experiments/legalization/legalization.cpp

+        wiring_reduction_exp.table();
+    }
+
+    return EXIT_SUCCESS;


warning: no header providing "EXIT_SUCCESS" is directly included [misc-include-cleaner]

experiments/legalization/legalization.cpp:30:

- #include <filesystem> + #include <cstdlib> + #include <filesystem>

github-actions · 2024-10-15T13:32:13Z

include/fiction/networks/views/extended_rank_view.hpp

+    {
+        assert(rank_level < ranks.size());
+        auto& rank  = ranks[rank_level];
+        rank_pos[n] = rank.size();


warning: implicit conversion loses integer precision: 'size_type' (aka 'unsigned long') to 'value_type' (aka 'unsigned int') [clang-diagnostic-shorten-64-to-32]

rank_pos[n] = rank.size(); ^

Additional context

include/fiction/networks/views/extended_rank_view.hpp:521: in instantiation of member function 'fiction::extended_rank_view<fiction::virtual_pi_networkfiction::technology_network>::insert_in_rank' requested here

insert_in_rank(n, i); ^

include/fiction/networks/views/extended_rank_view.hpp:140: in instantiation of member function 'fiction::extended_rank_view<fiction::virtual_pi_networkfiction::technology_network>::init_ranks' requested here

init_ranks(ranks); ^

include/fiction/algorithms/network_transformation/node_duplication_planarization.hpp:647: in instantiation of member function 'fiction::extended_rank_view<fiction::virtual_pi_networkfiction::technology_network>::extended_rank_view' requested here

return extended_rank_view(virtual_ntk, ntk_lvls_new); ^

include/fiction/algorithms/network_transformation/node_duplication_planarization.hpp:706: in instantiation of member function 'fiction::detail::node_duplication_planarization_implfiction::technology_network::run' requested here

auto result = p.run(ntk_lvls_new); ^

experiments/legalization/legalization.cpp:114: in instantiation of function template specialization 'fiction::node_duplication_planarizationfiction::technology_network' requested here

const auto planarized_b = fiction::node_duplication_planarization<fiction::technology_network>(b); ^

github-actions · 2024-10-15T13:32:13Z

include/fiction/networks/virtual_pi_network.hpp

+     * @param fn The function to be applied to each primary input.
+     */
+    template <typename Fn>
+    void foreach_virtual_pi(Fn&& fn) const


warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]

void foreach_virtual_pi(Fn&& fn) const ^

github-actions · 2024-10-15T13:32:13Z

include/fiction/networks/virtual_pi_network.hpp

+     * @param fn The function to be applied to each primary input.
+     */
+    template <typename Fn>
+    void foreach_virtual_ci(Fn&& fn) const


warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]

void foreach_virtual_ci(Fn&& fn) const ^

github-actions · 2024-10-15T13:32:13Z

include/fiction/networks/virtual_pi_network.hpp

+
+#if (PROGRESS_BARS)
+        // initialize a progress bar
+        mockturtle::progress_bar bar{static_cast<uint32_t>(ntk.num_gates()), "[i] network conversion: |{0}|"};


warning: no type named 'progress_bar' in namespace 'mockturtle' [clang-diagnostic-error]

mockturtle::progress_bar bar{static_cast<uint32_t>(ntk.num_gates()), "[i] network conversion: |{0}|"}; ^

github-actions · 2024-10-15T13:32:13Z

include/fiction/networks/virtual_pi_network.hpp

+    Ntk        ntk;
+    TopoNtkSrc ntk_topo;
+
+    [[nodiscard]] std::pair<Ntk, mockturtle::node_map<mockturtle::signal<Ntk>, Ntk>>


warning: no header providing "mockturtle::node_map" is directly included [misc-include-cleaner]

include/fiction/networks/virtual_pi_network.hpp:11:

- #include <mockturtle/views/topo_view.hpp> + #include <mockturtle/utils/node_map.hpp> + #include <mockturtle/views/topo_view.hpp>

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 44. Check the log or trigger a new build to see more.

github-actions · 2024-10-16T10:45:14Z

experiments/legalization/legalization.cpp

+        // check equivalence
+        mockturtle::equivalence_checking_stats st;
+        const auto                             cec_m = mockturtle::equivalence_checking(
+            *fiction::virtual_miter<fiction::technology_network>(benchmark_network, planarized_b), {}, &st);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

*fiction::virtual_miter<fiction::technology_network>(benchmark_network, planarized_b), {}, &st); ^

github-actions · 2024-10-16T10:45:14Z

experiments/legalization/legalization.cpp

+            fiction::clocked_layout<fiction::tile_based_layout<fiction::cartesian_layout<fiction::offset::ucoord_t>>>>;
+        auto layout = fiction::orthogonal<gate_layout>(planarized_b, {}, &stats);
+
+        fiction::gate_level_drv_params ps_d{};


warning: variable 'ps_d' of type 'fiction::gate_level_drv_params' can be declared 'const' [misc-const-correctness]

Suggested change

fiction::gate_level_drv_params ps_d{};

fiction::gate_level_drv_params const ps_d{};

github-actions · 2024-10-16T10:45:14Z

experiments/legalization/legalization.cpp

+            mockturtle::equivalence_checking_stats st_o;
+
+            const auto ce = mockturtle::equivalence_checking(*miter, {}, &st_o);
+            eq            = ce.value();


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

eq = ce.value(); ^

github-actions · 2024-10-16T10:45:14Z

experiments/legalization/legalization.cpp

+        // log results
+        wiring_reduction_exp(benchmark, benchmark_network.num_pis(), planarized_b.num_virtual_pis(),
+                             benchmark_network.num_pos(), benchmark_network.num_gates(), b.num_gates(),
+                             planarized_b.num_gates(), is_planar, cec_m.value(), eq);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

planarized_b.num_gates(), is_planar, cec_m.value(), eq); ^

github-actions · 2024-10-16T10:45:14Z

experiments/legalization/legalization.cpp

+        wiring_reduction_exp.table();
+    }
+
+    return EXIT_SUCCESS;


warning: no header providing "EXIT_SUCCESS" is directly included [misc-include-cleaner]

experiments/legalization/legalization.cpp:30:

- #include <filesystem> + #include <cstdlib> + #include <filesystem>

github-actions · 2024-10-16T10:45:17Z

include/fiction/networks/virtual_pi_network.hpp

+     * @param fn The function to be applied to each primary input.
+     */
+    template <typename Fn>
+    void foreach_virtual_pi(Fn&& fn) const


warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]

void foreach_virtual_pi(Fn&& fn) const ^

github-actions · 2024-10-16T10:45:17Z

include/fiction/networks/virtual_pi_network.hpp

+     * @param fn The function to be applied to each primary input.
+     */
+    template <typename Fn>
+    void foreach_virtual_ci(Fn&& fn) const


warning: forwarding reference parameter 'fn' is never forwarded inside the function body [cppcoreguidelines-missing-std-forward]

void foreach_virtual_ci(Fn&& fn) const ^

github-actions · 2024-10-16T10:45:17Z

include/fiction/networks/virtual_pi_network.hpp

+    Ntk        ntk;
+    TopoNtkSrc ntk_topo;
+
+    [[nodiscard]] std::pair<Ntk, mockturtle::node_map<mockturtle::signal<Ntk>, Ntk>>


warning: no header providing "mockturtle::node_map" is directly included [misc-include-cleaner]

include/fiction/networks/virtual_pi_network.hpp:11:

- #include <mockturtle/views/topo_view.hpp> + #include <mockturtle/utils/node_map.hpp> + #include <mockturtle/views/topo_view.hpp>

github-actions · 2024-10-16T10:45:17Z

test/algorithms/network_transformation/buffer_removal.cpp

+    const auto removed = remove_buffer(tec);
+
+    mockturtle::equivalence_checking_stats st;
+    const auto cec_m = mockturtle::equivalence_checking(*mockturtle::miter<technology_network>(tec, removed), {}, &st);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

const auto cec_m = mockturtle::equivalence_checking(*mockturtle::miter<technology_network>(tec, removed), {}, &st); ^

github-actions · 2024-10-16T10:45:17Z

test/algorithms/network_transformation/buffer_removal.cpp

+    mockturtle::equivalence_checking_stats st;
+    const auto cec_m = mockturtle::equivalence_checking(*mockturtle::miter<technology_network>(tec, removed), {}, &st);
+    REQUIRE(cec_m.has_value());
+    CHECK(cec_m.value() == 1);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

CHECK(cec_m.value() == 1); ^

# Conflicts: # bindings/mnt/pyfiction/include/pyfiction/pybind11_mkdoc_docstrings.hpp

Signed-off-by: GitHub Actions <[email protected]>

github-actions

clang-tidy made some suggestions

There were too many comments to post at once. Showing the first 25 out of 32. Check the log or trigger a new build to see more.

github-actions · 2024-12-03T14:48:32Z

include/fiction/algorithms/network_transformation/node_duplication_planarization.hpp

+    node_pair(mockturtle::node<Ntk> node1, mockturtle::node<Ntk> node2, uint64_t delay_value) :
+            pair(node1, node2),
+            delay(delay_value),
+            fanin_pair(nullptr)


warning: field 'delay' will be initialized after field 'fanin_pair' [clang-diagnostic-reorder-ctor]

Suggested change

fanin_pair(nullptr)

fanin_pair(nullptr)),

delay(delay_value

Additional context

include/fiction/algorithms/network_transformation/node_duplication_planarization.hpp:324: in instantiation of member function 'fiction::detail::node_pairfiction::technology_network::node_pair' requested here

const node_pair<Ntk> pair = {nodes[0], nodes[0], ^

include/fiction/algorithms/network_transformation/node_duplication_planarization.hpp:404: in instantiation of function template specialization 'fiction::detail::calculate_pairsfiction::technology_network' requested here

auto combinations = calculate_pairs<Ntk>(fis); ^

include/fiction/algorithms/network_transformation/node_duplication_planarization.hpp:605: in instantiation of member function 'fiction::detail::node_duplication_planarization_implfiction::technology_network::compute_slice_delays' requested here

compute_slice_delays(po); ^

include/fiction/algorithms/network_transformation/node_duplication_planarization.hpp:706: in instantiation of member function 'fiction::detail::node_duplication_planarization_implfiction::technology_network::run' requested here

auto result = p.run(ntk_lvls_new); ^

test/algorithms/network_transformation/buffer_removal.cpp:90: in instantiation of function template specialization 'fiction::node_duplication_planarizationfiction::technology_network' requested here

auto planarized_b = fiction::node_duplication_planarization<fiction::technology_network>(_b, dps); ^

github-actions · 2024-12-03T14:48:32Z

include/fiction/algorithms/network_transformation/node_duplication_planarization.hpp

+    node_pair(mockturtle::node<Ntk> node1, mockturtle::node<Ntk> node2, uint64_t delay_value) :
+            pair(node1, node2),
+            delay(delay_value),
+            fanin_pair(nullptr)


warning: field 'delay' will be initialized after field 'fanin_pair' [clang-diagnostic-reorder-ctor]

Suggested change

fanin_pair(nullptr)

fanin_pair(nullptr)),

delay(delay_value

Additional context

include/fiction/algorithms/network_transformation/node_duplication_planarization.hpp:324: in instantiation of member function 'fiction::detail::node_pairfiction::technology_network::node_pair' requested here

const node_pair<Ntk> pair = {nodes[0], nodes[0], ^

include/fiction/algorithms/network_transformation/node_duplication_planarization.hpp:404: in instantiation of function template specialization 'fiction::detail::calculate_pairsfiction::technology_network' requested here

auto combinations = calculate_pairs<Ntk>(fis); ^

include/fiction/algorithms/network_transformation/node_duplication_planarization.hpp:605: in instantiation of member function 'fiction::detail::node_duplication_planarization_implfiction::technology_network::compute_slice_delays' requested here

compute_slice_delays(po); ^

include/fiction/algorithms/network_transformation/node_duplication_planarization.hpp:706: in instantiation of member function 'fiction::detail::node_duplication_planarization_implfiction::technology_network::run' requested here

auto result = p.run(ntk_lvls_new); ^

test/algorithms/network_transformation/node_duplication_planarization.cpp:41: in instantiation of function template specialization 'fiction::node_duplication_planarizationfiction::technology_network' requested here

auto planarized_maj = node_duplication_planarization<technology_network>(tec_b); ^

github-actions · 2024-12-03T14:48:32Z

include/fiction/algorithms/properties/check_planarity_balanced.hpp

+                                     {
+                                         uint32_t new_bound = bound;
+                                         ntk.foreach_fanin(n,
+                                                           [this, &n, &bound, &new_bound, &return_false](const auto& fi)


warning: lambda capture 'n' is not used [clang-diagnostic-unused-lambda-capture]

[this, &n, &bound, &new_bound, &return_false](const auto& fi) ^

Additional context

/usr/include/c++/13/type_traits:2557: in instantiation of function template specialization 'fiction::check_planarity_impl<fiction::extended_rank_viewmockturtle::aig_network>::run()::(anonymous class)::operator()' requested here

std::declval<_Fn>()(std::declval<_Args>()...) ^

/usr/include/c++/13/type_traits:2568: while substituting deduced template arguments into function template '_S_test' [with _Fn = (lambda at /github/workspace/include/fiction/algorithms/properties/check_planarity_balanced.hpp:46:38), _Args = (no value)]

typedef decltype(_S_test<_Functor, _ArgTypes...>(0)) type; ^

/usr/include/c++/13/type_traits:2574: in instantiation of template class 'std::__result_of_impl<false, false, (lambda at /github/workspace/include/fiction/algorithms/properties/check_planarity_balanced.hpp:46:38), unsigned long>' requested here

: public __result_of_impl< ^

/usr/include/c++/13/type_traits:2935: in instantiation of template class 'std::__invoke_result<(lambda at /github/workspace/include/fiction/algorithms/properties/check_planarity_balanced.hpp:46:38), unsigned long>' requested here

__void_t<typename _Result::type>> ^

/usr/include/c++/13/type_traits:3089: during template argument deduction for class template partial specialization '__is_invocable_impl<_Result, _Ret, true, __void_t>' [with _Result = std::__invoke_result<(lambda at /github/workspace/include/fiction/algorithms/properties/check_planarity_balanced.hpp:46:38), unsigned long>, _Ret = void]

: __is_invocable_impl<__invoke_result<_Fn, _ArgTypes...>, _Ret>::type ^

/usr/include/c++/13/type_traits:3089: (skipping 3 contexts in backtrace; use -ftemplate-backtrace-limit=0 to see all)

: __is_invocable_impl<__invoke_result<_Fn, _ArgTypes...>, _Ret>::type ^

libs/mockturtle/include/mockturtle/networks/detail/foreach.hpp:51: in instantiation of variable template specialization 'mockturtle::detail::is_callable_without_index_v<(lambda at /github/workspace/include/fiction/algorithms/properties/check_planarity_balanced.hpp:46:38), unsigned long, void>' requested here

is_callable_without_index_v<Fn, ElementType, void> || ^

include/fiction/networks/views/extended_rank_view.hpp:332: in instantiation of function template specialization 'mockturtle::detail::foreach_element<__gnu_cxx::__normal_iterator<const unsigned long *, std::vector>, unsigned long, (lambda at /github/workspace/include/fiction/algorithms/properties/check_planarity_balanced.hpp:46:38)>' requested here

mockturtle::detail::foreach_element(rank.cbegin(), rank.cend(), std::forward<Fn>(fn)); ^

include/fiction/algorithms/properties/check_planarity_balanced.hpp:44: in instantiation of function template specialization 'fiction::extended_rank_viewmockturtle::aig_network::foreach_node_in_rank<(lambda at /github/workspace/include/fiction/algorithms/properties/check_planarity_balanced.hpp:46:38)>' requested here

ntk.foreach_node_in_rank(r, ^

include/fiction/algorithms/properties/check_planarity_balanced.hpp:114: in instantiation of member function 'fiction::check_planarity_impl<fiction::extended_rank_viewmockturtle::aig_network>::run' requested here

const auto result = p.run(); ^

test/algorithms/properties/check_planarity_balanced.cpp:47: in instantiation of function template specialization 'fiction::check_planarity<fiction::extended_rank_viewmockturtle::aig_network>' requested here

const bool planar = check_planarity(tec_r); ^

github-actions · 2024-12-03T14:48:32Z

include/fiction/networks/views/extended_rank_view.hpp

+    {
+        for (auto l = 0; l < ranks.size(); ++l)
+        {
+            foreach_node_in_rank(l, std::forward<Fn>(fn));


warning: implicit conversion changes signedness: 'int' to 'uint32_t' (aka 'unsigned int') [clang-diagnostic-sign-conversion]

foreach_node_in_rank(l, std::forward<Fn>(fn)); ^

expanded from here

github-actions · 2024-12-03T14:48:32Z

include/fiction/networks/views/extended_rank_view.hpp

+    {
+        for (auto l = 0; l < ranks.size(); ++l)
+        {
+            foreach_gate_in_rank(l, std::forward<Fn>(fn));


warning: implicit conversion changes signedness: 'int' to 'uint32_t' (aka 'unsigned int') [clang-diagnostic-sign-conversion]

foreach_gate_in_rank(l, std::forward<Fn>(fn)); ^

Additional context

include/fiction/networks/virtual_pi_network.hpp:391: in instantiation of function template specialization 'fiction::extended_rank_view<fiction::virtual_pi_networkfiction::technology_network>::foreach_gate<(lambda at /github/workspace/include/fiction/networks/virtual_pi_network.hpp:393:13)>' requested here

ntk_topo.foreach_gate( ^

include/fiction/networks/virtual_pi_network.hpp:560: in instantiation of member function 'fiction::detail::delete_virtual_pis_impl<fiction::extended_rank_view<fiction::virtual_pi_networkfiction::technology_network>>::run' requested here

auto result = p.run(); ^

include/fiction/algorithms/verification/virtual_miter.hpp:23: in instantiation of function template specialization 'fiction::delete_virtual_pis<fiction::extended_rank_view<fiction::virtual_pi_networkfiction::technology_network>>' requested here

return delete_virtual_pis(network); ^

test/algorithms/network_transformation/node_duplication_planarization.cpp:45: in instantiation of function template specialization 'fiction::virtual_miter<fiction::technology_network, fiction::technology_network, fiction::extended_rank_view<fiction::virtual_pi_networkfiction::technology_network>>' requested here

mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(tec, planarized_maj), {}, &st); ^

github-actions · 2024-12-03T14:48:34Z

test/algorithms/network_transformation/node_duplication_planarization.cpp

+
+    mockturtle::equivalence_checking_stats st;
+    const auto                             cec_m =
+        mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(tec, planarized_maj), {}, &st);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(tec, planarized_maj), {}, &st); ^

github-actions · 2024-12-03T14:48:34Z

test/algorithms/network_transformation/node_duplication_planarization.cpp

+    const auto                             cec_m =
+        mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(tec, planarized_maj), {}, &st);
+    REQUIRE(cec_m.has_value());
+    CHECK(*cec_m == 1);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

CHECK(*cec_m == 1); ^

github-actions · 2024-12-03T14:48:34Z

test/algorithms/network_transformation/node_duplication_planarization.cpp

+
+    mockturtle::equivalence_checking_stats st;
+    const auto                             cec_m =
+        mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(aig, planarized_maj), {}, &st);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(aig, planarized_maj), {}, &st); ^

github-actions · 2024-12-03T14:48:35Z

test/algorithms/network_transformation/node_duplication_planarization.cpp

+    const auto                             cec_m =
+        mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(aig, planarized_maj), {}, &st);
+    REQUIRE(cec_m.has_value());
+    CHECK(*cec_m == 1);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

CHECK(*cec_m == 1); ^

github-actions · 2024-12-03T14:48:35Z

test/algorithms/network_transformation/node_duplication_planarization.cpp

+
+    mockturtle::equivalence_checking_stats st;
+    const auto                             cec_m =
+        mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(aig, planarized_maj), {}, &st);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(aig, planarized_maj), {}, &st); ^

github-actions

clang-tidy made some suggestions

github-actions · 2024-12-09T10:31:33Z

test/algorithms/network_transformation/node_duplication_planarization.cpp

+    const auto                             cec_m =
+        mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(aig, planarized_maj), {}, &st);
+    REQUIRE(cec_m.has_value());
+    CHECK(*cec_m == 1);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

CHECK(*cec_m == 1); ^

github-actions · 2024-12-09T10:31:33Z

test/algorithms/network_transformation/node_duplication_planarization.cpp

+
+    mockturtle::equivalence_checking_stats st;
+    const auto                             cec_m =
+        mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(aig, planarized_maj), {}, &st);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(aig, planarized_maj), {}, &st); ^

github-actions · 2024-12-09T10:31:33Z

test/algorithms/network_transformation/node_duplication_planarization.cpp

+    const auto                             cec_m =
+        mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(aig, planarized_maj), {}, &st);
+    REQUIRE(cec_m.has_value());
+    CHECK(*cec_m == 1);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

CHECK(*cec_m == 1); ^

github-actions · 2024-12-09T10:31:33Z

test/networks/views/extended_rank_view.cpp

+
+    mockturtle::equivalence_checking_stats st;
+    const auto                             maybe_cec_m =
+        mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(ntk, ntk_r), {}, &st);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(ntk, ntk_r), {}, &st); ^

github-actions · 2024-12-09T10:31:34Z

test/networks/views/extended_rank_view.cpp

+    const auto                             maybe_cec_m =
+        mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(ntk, ntk_r), {}, &st);
+    REQUIRE(maybe_cec_m.has_value());
+    const bool cec_m = *maybe_cec_m;


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

const bool cec_m = *maybe_cec_m; ^

github-actions · 2024-12-09T10:31:34Z

test/networks/views/extended_rank_view.cpp

+
+    mockturtle::equivalence_checking_stats st;
+    const auto                             maybe_cec_m =
+        mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(tec, vpi_r), {}, &st);


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(tec, vpi_r), {}, &st); ^

github-actions · 2024-12-09T10:31:34Z

test/networks/views/extended_rank_view.cpp

+    const auto                             maybe_cec_m =
+        mockturtle::equivalence_checking(*fiction::virtual_miter<technology_network>(tec, vpi_r), {}, &st);
+    REQUIRE(maybe_cec_m.has_value());
+    const bool cec_m = *maybe_cec_m;


warning: unchecked access to optional value [bugprone-unchecked-optional-access]

const bool cec_m = *maybe_cec_m; ^

hibenj and others added 30 commits June 12, 2024 10:41

Init files

0fa1a52

Rank Ntk Setup

1fab81f

Compute Delay for H-graph.

9f77eda

➕ Compute nodes of the next level choosing the smallest delay path.

35a5f6f

🎨 refactoring for readability

9d994a0

🎨 Node insertion for computing the next level nodes fixed.

4a88b42

🎨 Pi propagation and next_level computation fixed.

fa968ff

🎨 refactoring for readability

488a588

➕ created virtual_pi_network.hpp and virtual_pi_network.cpp (test cas…

fe10893

…es have to be written as indicated in the ToDo)

🎨 output iterators adjusted after rmoving virtual PIs. Test cases mod…

5319bf4

…ified

🎨 redefinition of size() for code consistency

93d71c5

🎨 redefinition of functions.

cb22aa9

➕ added extended_rank_view.cpp and extended_rank_view.cpp.

2e82517

🎨 extended_rank_view is a rank_view with additional modify_rank and c…

d853052

…heck_validity functions

🎨 remove_virtual_input_nodes fixed. Take care of input and output ite…

85bf4b4

…rators.

➕ network creation added. Only 1-ary and 2-ary functions compatible atm

85dab93

🎨 code cleaned and test case added

4e5b9ba

🎨 changed virt_pi storage to shared_ptr and handle node deletion for …

6f4c78e

…equivalence checking inside the extended rank view.

🎨 cleaned and documented virtual_pi_network files

eade532

Merge branch 'cda-tum:main' into legalization

37f8acc

🎨 cleaned and documented extended_rank_view files

326d6a4

🎨 small adjustments to enable extended_rank_view

d2b1a57

🎨 rank computation added

db6a668

➕ planarity check added. The check requires a balanced network and al…

e94b479

…so a rank_view.

🎨 bugs with gather_fanin_signals removed. Documentation updated.

1b77a89

🎨 create_virtualPi_network from levels moved to virtual_pi_network.hp…

0e2f63d

…p as constructor.

🎨 updated documentation check_planarity.hpp

0d5dc55

🎨 small adjustments

afd38fb

Merge branch 'cda-tum:main' into legalization

39433d1

🎨 Incorporated pre-commit fixes

c22d3c3

hibenj added 2 commits September 23, 2024 11:36

🎨 fixed tests in check_planarity.cpp

2851358

Merge branch 'main' into legalization

04c3f0a

This comment was marked as duplicate.

Sign in to view

hibenj and others added 2 commits September 23, 2024 13:00

🎨 placed virtual_pi creation for duplicated nodes into node_duplicati…

9f4f59c

…on_planarization.hpp. The function has no use in any other context (so far).

📝 Update pyfiction docstrings

8321362

Signed-off-by: GitHub Actions <[email protected]>

This comment was marked as duplicate.

Sign in to view

hibenj and others added 2 commits September 23, 2024 18:12

🎨 cleaned up some code

accd04f

📝 Update pyfiction docstrings

c838dee

Signed-off-by: GitHub Actions <[email protected]>

This comment was marked as duplicate.

Sign in to view

hibenj and others added 5 commits September 24, 2024 15:11

➕ buffer_removal added.

42510ce

Merge remote-tracking branch 'origin/legalization' into legalization

02cb042

🎨 Incorporated pre-commit fixes

60f4038

🎨 added docstrings

b7a6229

Merge remote-tracking branch 'origin/legalization' into legalization

b71f5fd

# Conflicts: # include/fiction/algorithms/network_transformation/buffer_removal.hpp

This comment was marked as duplicate.

Sign in to view

hibenj and others added 3 commits October 14, 2024 11:52

🎨 renamed files

f5e0e49

🎨 experiments_file_cleaned

ede1ff0

🎨 Incorporated pre-commit fixes

089be08

github-actions bot reviewed Oct 14, 2024

View reviewed changes

submodules checked

b4df1c6

github-actions bot reviewed Oct 15, 2024

View reviewed changes

Merge branch 'main' into legalization

2d5c70a

github-actions bot reviewed Oct 16, 2024

View reviewed changes

hibenj and others added 2 commits December 3, 2024 14:04

Merge branch 'main' into legalization

42daacb

# Conflicts: # bindings/mnt/pyfiction/include/pyfiction/pybind11_mkdoc_docstrings.hpp

📝 Update pyfiction docstrings

df3b9f8

Signed-off-by: GitHub Actions <[email protected]>

github-actions bot reviewed Dec 3, 2024

View reviewed changes

Merge branch 'main' into legalization

1880f0a

github-actions bot reviewed Dec 9, 2024

View reviewed changes

	fiction::gate_level_drv_params ps_d{};
	fiction::gate_level_drv_params const ps_d{};

	uint32_t width() const noexcept
	[[nodiscard]] uint32_t width() const noexcept

Legalization #476

Are you sure you want to change the base?

Legalization #476

Conversation

hibenj commented Jul 17, 2024

Description

Checklist:

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

Drewniok commented Sep 26, 2024

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Oct 14, 2024

Choose a reason for hiding this comment

github-actions bot Oct 14, 2024

Choose a reason for hiding this comment

github-actions bot Oct 14, 2024

Choose a reason for hiding this comment

github-actions bot Oct 14, 2024

Choose a reason for hiding this comment

github-actions bot Oct 14, 2024

Choose a reason for hiding this comment

github-actions bot Oct 14, 2024

Choose a reason for hiding this comment

github-actions bot Oct 14, 2024

Choose a reason for hiding this comment

github-actions bot Oct 14, 2024

Choose a reason for hiding this comment

github-actions bot Oct 14, 2024

Choose a reason for hiding this comment

github-actions bot Oct 14, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Oct 15, 2024

Choose a reason for hiding this comment

github-actions bot Oct 15, 2024

Choose a reason for hiding this comment

github-actions bot Oct 15, 2024

Choose a reason for hiding this comment

github-actions bot Oct 15, 2024

Choose a reason for hiding this comment

github-actions bot Oct 15, 2024

Choose a reason for hiding this comment

github-actions bot Oct 15, 2024

Choose a reason for hiding this comment

github-actions bot Oct 15, 2024

Choose a reason for hiding this comment

github-actions bot Oct 15, 2024

Choose a reason for hiding this comment

github-actions bot Oct 15, 2024

Choose a reason for hiding this comment

github-actions bot Oct 15, 2024

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Oct 16, 2024

Choose a reason for hiding this comment

github-actions bot Oct 16, 2024

Choose a reason for hiding this comment

github-actions bot Oct 16, 2024

Choose a reason for hiding this comment

github-actions bot Oct 16, 2024

Choose a reason for hiding this comment

github-actions bot Oct 16, 2024

Choose a reason for hiding this comment

github-actions bot Oct 16, 2024

Choose a reason for hiding this comment

github-actions bot Oct 16, 2024

Choose a reason for hiding this comment

github-actions bot Oct 16, 2024

Choose a reason for hiding this comment

github-actions bot Oct 16, 2024

Choose a reason for hiding this comment

github-actions bot Oct 16, 2024

Choose a reason for hiding this comment

github-actions bot left a comment