Skip to content

Commit

Permalink
Bump min Python version in comments for typechecker configs
Browse files Browse the repository at this point in the history
  • Loading branch information
abravalheri committed Oct 30, 2024
1 parent 531c497 commit db2b253
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion mypy.ini
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ disable_error_code =

# CI should test for all versions, local development gets hints for oldest supported
# But our testing setup doesn't allow passing CLI arguments, so local devs have to set this manually.
# python_version = 3.8
# python_version = 3.9

exclude = (?x)(
# Avoid scanning Python files in generated folders
Expand Down
2 changes: 1 addition & 1 deletion pyrightconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"setuptools/_distutils",
],
// Our testing setup doesn't allow passing CLI arguments, so local devs have to set this manually.
// "pythonVersion": "3.8",
// "pythonVersion": "3.9",
// For now we don't mind if mypy's `type: ignore` comments accidentally suppresses pyright issues
"enableTypeIgnoreComments": true,
"typeCheckingMode": "basic",
Expand Down

0 comments on commit db2b253

Please sign in to comment.