Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for angular version 18 and 19 #628

Open
3 tasks done
brockhigg10 opened this issue Sep 3, 2024 · 1 comment
Open
3 tasks done

Support for angular version 18 and 19 #628

brockhigg10 opened this issue Sep 3, 2024 · 1 comment
Assignees
Labels
Dependencies development Development tasks enhancement New feature or request

Comments

@brockhigg10
Copy link
Contributor

Prerequisites | Prérequis

GC Design System Components Package and Version | Paquet et version des composants de Système de design GC

[email protected]

Current Behavior | Comportement observé

"I worked on creating a form in Angular using GCDS. Turns out it worked better than I anticipated: I was able to bind the values from my model to the GCDS components!

Here is the result: https://stackblitz.com/github/AlexisLeblancDFO/gcds-angular18-form?file=README.md

As you will notice when opening the link: there are multiple error messages that occur when installing GCDS.

The issue is that the latest version of GCDS is only compatible with Angular 16 and less (we are at version 18 now).

It may become an issue as the project gets bigger. At the moment, it’s the only issue I have with GCDS."

Expected Behavior | Comportement attendu

Would it be possible to release an version of GCDS that supports Angular 18?

System Info | Information sur le système

No response

Steps to Reproduce | Étapes pour reproduire le bogue

https://stackblitz.com/github/AlexisLeblancDFO/gcds-angular18-form?file=README.md

Code Reproduction URL | URL de reproduction du code

No response

Additional Information | Informations supplémentaires

No response

@daine daine changed the title bug: Angular (version 18) Support for angular version 18 Sep 4, 2024
@daine daine added the development Development tasks label Oct 2, 2024
@ethanWallace ethanWallace self-assigned this Nov 21, 2024
@adorayi adorayi changed the title Support for angular version 18 Support for angular version 18 and 19 Nov 26, 2024
@ethanWallace
Copy link
Collaborator

@daine I have tested setting the dependencies to [email protected] and [email protected] to see if the same strange build errors occur.

The react build will still fail with the same error and the react ssr now fails too with an error similar to the react error. The angular package did load fine though when using it in a test app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies development Development tasks enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants