Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add / import <mapml-viewer> to gcds under components/gcds-map #759

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

prushforth
Copy link

Add dependency on @maps4html/mapml

Update stencil config to copy mapml to dist output directory.

Update index.html with example <mapml-viewer>

Add gcds-map.stories.tsx

Make mapml a dependency, not a devDependency, since it must be present
at runtime / installed with product

Add dist/gcds/gcds-map as static resource directory for storybook.

Change how controls is implemented by stencil to make it consistent
with boolean attribute with default of false when not present

Make controlslist a multi-select in storybook

Make gcds-map a component only in name, created for the purpose of
importing the map client CSS rules in gcds-map.css.

Add global script to dynamically and conditionally import mapml.js;
global script can refer to other global script imports as required.

Include very basic gcds-map.css in build, integrate via run time load

Add mapml.js and gcds-map.css imports to storybook preview-head.html,
so that it appears in the iframe regardless of whether the <mapml-viewer>
has been rendered yet.

Add some basemap mapml (services) directory contents to component definition
for use in index.html and storybook

Co-authored-by: Pierre Dubois <[email protected]>

Summary | Résumé

1-3 sentence description of the changed you're proposing, including a link to
a GitHub Issue # or Trello card if applicable.


Description en 1 à 3 phrases de la modification proposée, avec un lien vers le
problème (« issue ») GitHub ou la fiche Trello, le cas échéant.

Test instructions | Instructions pour tester la modification

Sequential steps (1., 2., 3., ...) that describe how to test this change. This
will help a developer test things out without too much detective work. Also,
include any environmental setup steps that aren't in the normal README steps
and/or any time-based elements that this requires.


Étapes consécutives (1., 2., 3., …) qui décrivent la façon de tester la
modification. Elles aideront les développeurs à faire des tests sans avoir à
jouer au détective. Veuillez aussi inclure toutes les étapes de configuration
de l’environnement qui ne font pas partie des étapes normales dans le fichier
README et tout élément temporel requis.

Add dependency on @maps4html/mapml

Update stencil config to copy mapml to dist output directory.

Update index.html with example <mapml-viewer>

Add gcds-map.stories.tsx

Add dist/gcds/gcds-map as static resource directory for storybook.

Make controlslist a multi-select in storybook

Make gcds-map a component only in name, created for the purpose of
importing the map client CSS rules in gcds-map.css.

Add global script to dynamically and conditionally import mapml.js;
global script can refer to other global script imports as required.

Include gcds-map.css in build, integrate via run time load

Add mapml.js and gcds-map.css imports to storybook preview-head.html,
so that it appears in the iframe regardless of whether the <mapml-viewer>
has been rendered yet.

Add some basemap mapml (services) directory contents to component definition
for use in index.html and story

Add a test

Add jest, jest-environment-node to root node_modules
- this is necessary to successfully run tests in packages/web

Add gcds-map.d.ts, re-export from index.ts.
Leverage gcds-map.d.ts in gcds-map.e2e.ts a little bit

Fix issue with ts not liking
[Symbol.iterator]: function (): IterableIterator<File>
by adding dom.iterable to the lib section, fix discovered here:
sitelint.com/blog/solution-to-type-filelist-must-have-a-symbol-iterator-method-that-returns-an-iterator

Add dom.iterable to tsconfig.json everywhere

Add functional second story to map: hidden (basemap) layers.
Add current_conditions in en only (so far).

Add a Playground story

Add geojson default style example
Update current weather to comment out feature query
Add copying of geojson canada.json file into static assets

Update GeoJSON2MapMLExample story with styles.

Update GeoJSON2MapMLExample story parameters docs.source.code etc

Add DarkMode example with assets

Update dark mode example to be remote mapml, so that we can have an
explicit inline/remote example later.

Update overview, add inline vs remote MapML example

Add custom projection example

Add delimiter comments to code disclosure widget so that the Copy
button works, except for that there's no React code in this component

Co-authored-by: Pierre Dubois <[email protected]>
@prushforth prushforth force-pushed the gcds-map-import-only branch from 69447e5 to ac94826 Compare March 2, 2025 18:13
@prushforth prushforth marked this pull request as ready for review March 2, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant