Ensure Ruff checks formatting during CI checks (#2021)

* Ensure make test runs ruff format --check

* Update ruff extension cfg

- The VSCode ruff extension will no longer automatically remove unused imports but will still notify you they're incorrect
- Updated ruff to 0.8.2

.devcontainer/devcontainer.json

@@ -33,15 +33,12 @@
 				"vsliveshare.vsliveshare"
 			],
 			"settings": {
+				"ruff.lint.ignore": ["F401"],
+				"ruff.lint.run": "onSave",
+				"ruff.organizeImports": false,
 				"[python]": {
-					"ruff.lint.run": "onSave",
-					"editor.defaultFormatter": "charliermarsh.ruff",
-					"editor.formatOnSave": false,
-					"editor.codeActionsOnSave": {
-						"source.fixAll": "explicit"
-					}
-				},
-				"ruff.configurationPreference": "filesystemFirst"
+					"editor.defaultFormatter": "charliermarsh.ruff"
+				}
 			}
 		}
 	},

Makefile

@@ -61,7 +61,7 @@ run-gunicorn:
 
 .PHONY: format
 format:
-	ruff check --select I --fix .
+	ruff check --fix .
 	ruff check
 	ruff format .
 	mypy ./

pyproject.toml

@@ -79,7 +79,7 @@ mypy = "1.11.2"
 monkeytype = "23.3.0"
 poethepoet = "^0.24.4"
 pre-commit = "^3.7.1"
-ruff = "^0.6.9"
+ruff = "^0.8.2"
 
 # stubs libraries to keep mypy happy
 types-python-dateutil = "2.9.0.20241003"

scripts/run_tests.sh

@@ -31,6 +31,9 @@ display_result $? 1 "Code style check"
 ruff check --select I .
 display_result $? 1 "Import order check"
 
+ruff format --check .
+display_result $? 1 "Code format check"
+
 mypy ./
 display_result $? 1 "Type check"