Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design/admin panel #2044

Merged
merged 30 commits into from
Feb 27, 2025
Merged

Design/admin panel #2044

merged 30 commits into from
Feb 27, 2025

Conversation

amazingphilippe
Copy link
Contributor

@amazingphilippe amazingphilippe commented Jan 9, 2025

Summary | Résumé

Adds details to the admin panel to make our lives a bit easier:

  • Zebra striping on the live services table. Helps visually group sms and email counts.
  • Typographic adjustments on the live services table
  • Adds the main nav back in. No more layout shift
  • Use the empty component in empty table lists
  • Adding a rowspan on the row_heading macro. Nicer alignment in live service list.
  • Make branding previews more uniform
  • Spacing fixes in org user list
  • Add some red color tokens
  • Fix tests since I changed the live service table markup slightly

Test instructions | Instructions pour tester la modification

  • In admin panel
  • Have a look at the live services table
  • Have a look at admin branding settings (through org, through service)
  • Have a look at the org users list
  • Have a look at an empty list like complaints sometimes?

Copy link

github-actions bot commented Jan 9, 2025

Copy link

@amazingphilippe amazingphilippe marked this pull request as ready for review February 18, 2025 18:08
Copy link
Contributor

@smcmurtry smcmurtry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great! I find the new table in admin is much easier to read.

I was able to see the empty list by testing locally, it looks good:
Screenshot 2025-02-20 at 1 36 13 PM

I noticed some misalignment on the Organisation team members admin page when you invite a new user. The row for the invited user doesn't look consistent with the other rows:

Screenshot 2025-02-19 at 4 30 10 PM

@amazingphilippe amazingphilippe merged commit 2737a18 into main Feb 27, 2025
11 checks passed
@amazingphilippe amazingphilippe deleted the design/admin-panel branch February 27, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants