Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws auth Take two #1775

Merged
merged 8 commits into from
Feb 25, 2025
Merged

Aws auth Take two #1775

merged 8 commits into from
Feb 25, 2025

Conversation

ben851
Copy link
Contributor

@ben851 ben851 commented Feb 24, 2025

Summary | Résumé

Trying to get terraform to assume the correct role to update the aws-auth config map in staging

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

TF Apply still works
We can still access the staging aws cluster

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@ben851 ben851 requested a review from sastels February 24, 2025 19:45
@ben851 ben851 requested a review from jimleroyer as a code owner February 24, 2025 19:45
Copy link
Contributor

@P0NDER0SA P0NDER0SA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@ben851 ben851 merged commit 5fca0ee into main Feb 25, 2025
3 checks passed
@ben851 ben851 deleted the aws-auth branch February 25, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants