Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Auth via TF on Dev #1778

Merged
merged 1 commit into from
Feb 25, 2025
Merged

AWS Auth via TF on Dev #1778

merged 1 commit into from
Feb 25, 2025

Conversation

ben851
Copy link
Contributor

@ben851 ben851 commented Feb 25, 2025

Summary | Résumé

Switch to terraform managing aws auth in dev create

Related Issues | Cartes liées

Test instructions | Instructions pour tester la modification

Verify create dev works properly on Monday

Release Instructions | Instructions pour le déploiement

None.

Reviewer checklist | Liste de vérification du réviseur

  • This PR does not break existing functionality.
  • This PR does not violate GCNotify's privacy policies.
  • This PR does not raise new security concerns. Refer to our GC Notify Risk Register document on our Google drive.
  • This PR does not significantly alter performance.
  • Additional required documentation resulting of these changes is covered (such as the README, setup instructions, a related ADR or the technical documentation).

⚠ If boxes cannot be checked off before merging the PR, they should be moved to the "Release Instructions" section with appropriate steps required to verify before release. For example, changes to celery code may require tests on staging to verify that performance has not been affected.

@ben851 ben851 requested a review from a team February 25, 2025 18:26
@ben851 ben851 requested a review from jimleroyer as a code owner February 25, 2025 18:26
@ben851 ben851 changed the title try AWS Auth via TF on Dev Feb 25, 2025
sastels
sastels reviewed Feb 25, 2025
View reviewed changes
.github/workflows/terragrunt_create_dev_environment.yml
@@ -969,17 +1056,6 @@ jobs:
aws eks update-kubeconfig --name notification-canada-ca-dev-eks-cluster
kubectl config rename-context arn:aws:eks:ca-central-1:${{env.ACCOUNT_ID}}:cluster/notification-canada-ca-dev-eks-cluster dev

- name: terragrunt apply k8s-fix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need this anymore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope - it was a hack for aws-auth :)

@ben851 ben851 merged commit 820c4db into main Feb 25, 2025
3 checks passed
@ben851 ben851 deleted the dev-create-aws-auth-1 branch February 25, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sastels sastels sastels approved these changes

@jimleroyer jimleroyer Awaiting requested review from jimleroyer jimleroyer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ben851 @sastels