chore: update handling for next element id #4695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://g7pumfco5olxasmclzpqmg7aeu0slums.lambda-url.ca-central-1.on.aws/ |
timarney
force-pushed
the
next-element-id
branch
from
ecdebb7 to
6666a28
Compare
timarney
force-pushed
the
next-element-id
branch
from
d24cc25 to
529cd27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Note:
👉 This update isn't exhaustive for forms built prior to the
lastGeneratedElementIdexisting.For example it doesn't try to
auto-setthe lastGeneratedElementId when importing a form. It will update the value once an element is added.While this should generate "unique" ids for elements the feature PR for question tags will provide a more robust solution
#4694