[WIP] Preliminary work attaching tags to responses #4700
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsamojlenko
commented
Nov 25, 2024
Comment on lines
+25
to
+32
|
|
||
| // If there is a question tag, store it with the response | ||
| // if (element.properties.tag) { | ||
| // formData[tuple[0]] = JSON.stringify({ | ||
| // answer: tuple[1], | ||
| // tag: element.properties.tag, | ||
| // }); | ||
| // } |
There was a problem hiding this comment.
Commented out for now.
This mostly works, but the object causes problems further down the chain in rehydrateFormResponses.ts which will need updating.
🧪 Review environmenthttps://ohiusozjmxylms5zxrk4st6fta0kamex.lambda-url.ca-central-1.on.aws/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
Re: #4378
See "Next steps" section on related PR: #4694
This PR continues the work in #4694 adding tags to responses on their way into the Vault.