[TEAMMATES#12663] Instructor's Student Records Page: Tooltips for com…

…ments (TEAMMATES#12676) * Fix comment tooltip causing the text to go into next line * Update snapshot test --------- Co-authored-by: YX Z <[email protected]> Co-authored-by: Wei Qing <[email protected]> Co-authored-by: Dominic Lim <[email protected]> Co-authored-by: Jason Qiu <[email protected]>
cedricongjh · Feb 20, 2024 · a36926b · a36926b
1 parent 94c22f6
commit a36926b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 26 deletions.
diff --git a/src/web/app/components/comment-box/comment-row/comment-row.component.html b/src/web/app/components/comment-box/comment-row/comment-row.component.html
@@ -19,7 +19,7 @@
         <span class="by-response-giver text-secondary" *ngIf="isFeedbackParticipantComment">
           Comment by response giver.
         </span>
-        <span class="text-secondary" *ngIf="!isFeedbackParticipantComment">
+        <ng-container class="text-secondary" *ngIf="!isFeedbackParticipantComment">
           <span class="comment-giver-name">{{ model.commentGiverName ? model.commentGiverName : model.originalComment.commentGiver }} commented at </span>
           <span class="ngb-tooltip-class" style="margin-right: .25rem;" [ngbTooltip]="model.originalComment.createdAt | formatDateDetail: model.timezone!">
             {{ model.originalComment.createdAt | formatDateBrief: model.timezone! }}</span>
@@ -28,7 +28,7 @@
             <span id="last-editor-name" style="margin-right: .25rem;" class="ngb-tooltip-class"
                   [ngbTooltip]="model.originalComment.lastEditedAt | formatDateDetail: model.timezone!">edited by {{ model.lastEditorName ? model.lastEditorName : model.originalComment.lastEditorEmail }}</span>
           </ng-container>
-        </span>
+        </ng-container>
 
         <i class="fa fa-eye" aria-hidden="true" ngbTooltip="This response comment is visible to {{ visibilityStateMachine.getVisibilityTypesUnderVisibilityControl(CommentVisibilityControl.SHOW_COMMENT) | commentVisibilityTypesJointName }}"></i>
 

diff --git a/...ents/question-response-panel/__snapshots__/question-response-panel.component.spec.ts.snap b/...ents/question-response-panel/__snapshots__/question-response-panel.component.spec.ts.snap
@@ -386,19 +386,15 @@ exports[`QuestionResponsePanelComponent should snap with feedback session with q
                                                 class="col-12"
                                               >
                                                 <span
-                                                  class="text-secondary"
+                                                  class="comment-giver-name"
                                                 >
-                                                  <span
-                                                    class="comment-giver-name"
-                                                  >
-                                                    comment-giver-1 commented at 
-                                                  </span>
-                                                  <span
-                                                    class="ngb-tooltip-class"
-                                                    style="margin-right: .25rem;"
-                                                  >
-                                                     17 Jan 1:09 PM
-                                                  </span>
+                                                  comment-giver-1 commented at 
+                                                </span>
+                                                <span
+                                                  class="ngb-tooltip-class"
+                                                  style="margin-right: .25rem;"
+                                                >
+                                                   17 Jan 1:09 PM
                                                 </span>
                                                 <i
                                                   aria-hidden="true"
@@ -934,19 +930,15 @@ exports[`QuestionResponsePanelComponent should snap with questions and responses
                                                 class="col-12"
                                               >
                                                 <span
-                                                  class="text-secondary"
+                                                  class="comment-giver-name"
+                                                >
+                                                  comment-giver-1 commented at 
+                                                </span>
+                                                <span
+                                                  class="ngb-tooltip-class"
+                                                  style="margin-right: .25rem;"
                                                 >
-                                                  <span
-                                                    class="comment-giver-name"
-                                                  >
-                                                    comment-giver-1 commented at 
-                                                  </span>
-                                                  <span
-                                                    class="ngb-tooltip-class"
-                                                    style="margin-right: .25rem;"
-                                                  >
-                                                     17 Jan 1:09 PM
-                                                  </span>
+                                                   17 Jan 1:09 PM
                                                 </span>
                                                 <i
                                                   aria-hidden="true"