Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix site rendering #281

Merged
merged 2 commits into from
Mar 28, 2025
Merged

docs: fix site rendering #281

merged 2 commits into from
Mar 28, 2025

Conversation

jcstein
Copy link
Member

@jcstein jcstein commented Mar 27, 2025

Overview

The site renders the tip callout as "[!TIP]" on the site.

Screenshot 2025-03-27 at 17 19 41

The site renders the tip callout as "[!TIP]" on the site.
@jcstein
Copy link
Member Author

jcstein commented Mar 27, 2025

Screenshot 2025-03-27 at 17 20 00 and should still look OK on Github. if this isn't clear enough on github though without the TIP indicator, please feel free to close this PR Screenshot 2025-03-27 at 17 20 34

@jcstein jcstein self-assigned this Mar 27, 2025
@@ -9,7 +9,6 @@
| category | Core |
| created | 2023-12-08 |

> [!TIP]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dang this looks good in GitHub but doesn't look good in mdbook 😢

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me ask claude what's up

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh sorry no need to change the PR. I meant [!TIP] renders nicely in GitHub but if it's broken in mdbook then we can remove it.

@jcstein
Copy link
Member Author

jcstein commented Mar 27, 2025

Screenshot 2025-03-27 at 17 27 54 Screenshot 2025-03-27 at 17 29 08 thoughts @rootulp ?

@jcstein
Copy link
Member Author

jcstein commented Mar 27, 2025

at least there's some color back on github now
Screenshot 2025-03-27 at 17 30 20

@rootulp
Copy link
Collaborator

rootulp commented Mar 27, 2025

LGTM, ty

@jcstein jcstein merged commit 24154ad into main Mar 28, 2025
2 checks passed
@jcstein jcstein deleted the jcstein-patch-1 branch March 28, 2025 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants