Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instruct GoReleaser to use latest tag plumbed in via Github action #4081

Open
rootulp opened this issue Dec 4, 2024 · 0 comments · May be fixed by #4094
Open

Instruct GoReleaser to use latest tag plumbed in via Github action #4081

rootulp opened this issue Dec 4, 2024 · 0 comments · May be fixed by #4094
Assignees
@rootulp
Labels
nice to have item is not blocking or required.

Comments

@rootulp
Copy link
Collaborator

rootulp commented Dec 4, 2024

Problem

GoReleaser gets confused when there are multiple tags on the same commit (i.e. 3.0.2-mocha, 3.0.2-arabica). It doesn't know which one is "latest" so it may fail to attach binaries to one release if it thinks it is running on the other release.

To resolve this, we introduced a workaround to determine the most recent tag based on SemVer + Celestia testnet names. See #3977

Proposal

celestia-node just merged celestiaorg/celestia-node#3979 which seems to resolve the same issue. We should consider adopting it instead.
@rootulp rootulp added the nice to have item is not blocking or required. label Dec 4, 2024
@rootulp rootulp self-assigned this Dec 7, 2024
@rootulp rootulp linked a pull request Dec 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rootulp rootulp

Labels
nice to have item is not blocking or required.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(goreleaser): use latest tag from GitHub action rootulp/celestia-app
1 participant
@rootulp