-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(goreleaser): use latest tag from GitHub action #4094
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe pull request introduces modifications to the GitHub Actions workflows and the Makefile to enhance the handling of release events. The Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (3)
.github/workflows/ci-release.yml
(2 hunks).github/workflows/goreleaser.yml
(3 hunks)Makefile
(3 hunks)
🧰 Additional context used
🪛 actionlint (1.7.4)
.github/workflows/goreleaser.yml
18-18: shellcheck reported issue in this script: SC2086:info:1:71: Double quote to prevent globbing and word splitting
(shellcheck)
41-41: shellcheck reported issue in this script: SC2086:info:1:71: Double quote to prevent globbing and word splitting
(shellcheck)
🔇 Additional comments (6)
.github/workflows/ci-release.yml (2)
12-13
: LGTM! Well-defined release event trigger.
The addition of the release event trigger with the 'published' type ensures precise control over when the workflow runs.
27-27
: LGTM! Appropriate conditional execution.
The condition ensures the goreleaser job only runs during release events, preventing unnecessary executions.
.github/workflows/goreleaser.yml (2)
10-10
: LGTM! Consistent conditional execution.
Both jobs are properly configured to run only during release events, maintaining consistency with ci-release.yml.
Also applies to: 31-31
27-28
: LGTM! Proper environment variable configuration.
The GORELEASER_CURRENT_TAG is correctly passed to the required steps.
Also applies to: 50-51
Makefile (2)
1-1
: LGTM! Robust version detection.
The VERSION variable now properly handles cases with and without tags, with a fallback to the commit hash.
207-207
: LGTM! Consistent environment variable usage.
The GORELEASER_CURRENT_TAG is correctly used in both goreleaser commands, maintaining consistency with the workflow changes.
Also applies to: 225-225
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utAck
Closes #4081
Testing
On my fork all of these releases used the correct tag and uploaded prebuilt binaries.