chore(test/interchain): upgrade cosmos-sdk and celestia-core versions #4107
Conversation
tskoyo
requested review from
rootulp and
rach-id
and removed request for
a team
📝 WalkthroughWalkthroughThe Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🔇 Additional comments (3)test/interchain/go.mod (3)Line range hint The direct dependencies are minimal and appropriate for an interchain test module.
The updates to Prometheus and OpenTelemetry packages are significant. Let's verify there are no known security issues with these versions. Also applies to: 177-179 ✅ Verification successfulPrometheus and OpenTelemetry dependencies are secure at current versions The security check reveals:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for security advisories for prometheus and opentelemetry packages
# Check for Prometheus client security advisories
gh api graphql -f query='
{
securityVulnerabilities(first: 5, ecosystem: GO, package: "github.com/prometheus/client_golang") {
nodes {
advisory {
summary
severity
publishedAt
}
vulnerableVersionRange
firstPatchedVersion {
identifier
}
}
}
}'
# Check for OpenTelemetry security advisories
gh api graphql -f query='
{
securityVulnerabilities(first: 5, ecosystem: GO, package: "go.opentelemetry.io/otel") {
nodes {
advisory {
summary
severity
publishedAt
}
vulnerableVersionRange
firstPatchedVersion {
identifier
}
}
}
}'
Length of output: 932
The updates to cosmos-sdk and tendermint versions match the PR objectives to resolve version conflicts. Let's verify the compatibility of these versions. Also applies to: 232-232 ✅ Verification successfulVersion updates are consistently applied across the codebase The verification shows that both version updates (cosmos-sdk v1.25.0-sdk-v0.46.16 and celestia-core v1.44.0-tm-v0.34.35) are consistently applied in both the main 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Verify version compatibility between cosmos-sdk and tendermint
# Check for any known issues or breaking changes between these specific versions
rg -l "breaking.*change|compatibility.*issue" -g "CHANGELOG.md" | while read -r file; do
echo "=== Checking $file ==="
rg "v1.25.0-sdk-v0.46.16|v1.44.0-tm-v0.34.35" "$file" -C 5
done
Length of output: 227 Script: #!/bin/bash
# Let's try a different approach to verify version compatibility
# 1. Check go.mod files for these specific versions
echo "=== Checking go.mod files for version references ==="
rg "v1.25.0-sdk-v0.46.16|v1.44.0-tm-v0.34.35" -g "go.mod"
# 2. Look for any version-related files or documentation
echo -e "\n=== Checking for version documentation ==="
fd -g "*version*.{md,txt}" -g "*UPGRADE*.{md,txt}" -g "CHANGELOG.md"
# 3. Check for any dependency constraints or requirements
echo -e "\n=== Checking dependency requirements ==="
rg "require.*cosmos-sdk|require.*tendermint" -g "go.mod"
Length of output: 1085 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
📝 WalkthroughWalkthroughThe Changes
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🔇 Additional comments (4)test/interchain/go.mod (4)Line range hint The module configuration and direct dependencies are well-structured and aligned with the testing requirements.
The updates to cosmos-sdk and tendermint versions match the PR objectives: - github.com/cosmos/cosmos-sdk => github.com/celestiaorg/cosmos-sdk v1.24.0-sdk-v0.46.16
+ github.com/cosmos/cosmos-sdk => github.com/celestiaorg/cosmos-sdk v1.25.0-sdk-v0.46.16
- github.com/tendermint/tendermint => github.com/celestiaorg/celestia-core v0.34.29
+ github.com/tendermint/tendermint => github.com/celestiaorg/celestia-core v1.44.0-tm-v0.34.35Line range hint The replacement of - github.com/strangelove-ventures/interchaintest/v6 => github.com/rootulp/interchaintest/v6 v6.1.0This is noted as temporary until PR #1051 is merged. Line range hint Several dependencies have significant version updates. While these updates are generally good for security and features, please ensure compatibility, particularly for:
✅ Verification successfulDependency updates appear safe to proceed The version updates are minor and patch releases that maintain backward compatibility:
🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for breaking changes in major version updates
# Check if the updated versions have any known compatibility issues
echo "Checking prometheus/client_golang compatibility..."
gh api repos/prometheus/client_golang/releases/tags/v1.20.3 | jq -r '.body' | grep -i "breaking"
echo "Checking opentelemetry-go compatibility..."
gh api repos/open-telemetry/opentelemetry-go/releases/tags/v1.30.0 | jq -r '.body' | grep -i "breaking"
Length of output: 402 Script: #!/bin/bash
# Let's try a different approach to check for potential breaking changes
# by examining the go.mod changes and dependency usage
# Find all Go files that might use these dependencies
echo "Files using prometheus/client_golang:"
rg --type go "github.com/prometheus/client_golang" -l
echo -e "\nFiles using opentelemetry:"
rg --type go "go.opentelemetry.io/otel" -l
echo -e "\nChecking go.mod history for these dependencies:"
git diff HEAD~1 test/interchain/go.mod | grep -E "github.com/prometheus/|opentelemetry"
# Check if there are any replace directives for these packages
echo -e "\nChecking replace directives:"
grep -A 5 "^replace" test/interchain/go.mod
Length of output: 2463 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
| cloud.google.com/go/iam v1.1.6 // indirect | ||
| cloud.google.com/go/storage v1.37.0 // indirect | ||
| cosmossdk.io/errors v1.0.1 // indirect | ||
| filippo.io/edwards25519 v1.0.0-rc.1 // indirect | ||
| github.com/99designs/go-keychain v0.0.0-20191008050251-8e49817e8af4 // indirect | ||
| github.com/99designs/keyring v1.2.2 // indirect | ||
| github.com/BurntSushi/toml v1.3.2 // indirect | ||
| github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c // indirect |
There was a problem hiding this comment.
this version number looks suspect so I looked into why
$ go mod why github.com/BurntSushi/toml
go: downloading github.com/google/pprof v0.0.0-20240827171923-fa2c70bbbfe5
go: downloading github.com/cncf/xds/go v0.0.0-20240423153145-555b57ec207b
# github.com/BurntSushi/toml
github.com/celestiaorg/celestia-app/test/interchain/chainspec
github.com/strangelove-ventures/interchaintest/v6/testutil
github.com/BurntSushi/toml
and then I tried the bumping the versions used in the replace directive and ran go mod tidy and got the same result so seems fine
rootulp
changed the title
Updated the dependency versions in the
test/interchainmodule. This resolves build conflicts caused by differing replacement directives for:github.com/cosmos/cosmos-sdkgithub.com/tendermint/tendermintChanges:
github.com/cosmos/cosmos-sdktogithub.com/celestiaorg/cosmos-sdk v1.25.0-sdk-v0.46.16.github.com/tendermint/tenderminttogithub.com/tendermint/tendermint => github.com/celestiaorg/celestia-core v1.44.0-tm-v0.34.35.Tested with
make buildandmake testto ensure compatibility.