Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch default database backend from goleveldb to pebble #1636

Draft
wants to merge 8 commits into
base: v0.34.x-celestia
Choose a base branch
from

Conversation

DeVikingMark
Copy link

Description

  • Changes default database backend from goleveldb to pebble for better performance
  • Updates all configs and tests to use pebble by default
  • Adds pebble support to database compaction tool
  • Maintains backwards compatibility with existing goleveldb databases

Changes

  • Changed default DBBackend to "pebble" in config
  • Updated e2e tests and generators to use pebble
  • Added pebble support to experimental-compact command
  • Updated documentation

Closes #1596

Migration

Existing nodes will need to resync their chain to switch to pebble. No action required to continue using goleveldb.

Testing

  • Run e2e tests
  • Test database compaction with both goleveldb and pebble
  • Verify node syncs with both database backends

@DeVikingMark DeVikingMark requested a review from a team as a code owner February 26, 2025 01:42
@DeVikingMark DeVikingMark requested review from rootulp and rach-id and removed request for a team February 26, 2025 01:42
@rootulp rootulp removed their request for review February 26, 2025 03:15
@evan-forbes
Copy link
Member

thanks for trying this out @DeVikingMark

it might be easier and it would be more valuable to do this after the upgrade to v0.38, since that's what we will use long term. It might even already be done there.

tests must be passing before we can merge 🙂

@rootulp rootulp marked this pull request as draft February 26, 2025 14:14
@rootulp rootulp changed the title Switch default database backend from goleveldb to pebble feat: switch default database backend from goleveldb to pebble Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use pebble instead of goleveldb
2 participants