Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump go-header with bifurcation #3982

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

feat: bump go-header with bifurcation #3982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
86381f1
feat: bump go-header with bifurcation
cristaloleg Dec 6, 2024
119c6d6
fix new param
cristaloleg Dec 6, 2024
30c5bc1
test
cristaloleg Dec 6, 2024
21fabd6
temp fix
cristaloleg Dec 6, 2024
f788aa8
proper fix
cristaloleg Dec 6, 2024
4bbfde4
upd
cristaloleg Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ require (
github.com/benbjohnson/clock v1.3.5
github.com/celestiaorg/celestia-app/v3 v3.0.2
github.com/celestiaorg/go-fraud v0.2.1
github.com/celestiaorg/go-header v0.6.3
github.com/celestiaorg/go-header v0.6.3-0.20250122141912-eb13b856d1f3
github.com/celestiaorg/go-libp2p-messenger v0.2.0
github.com/celestiaorg/go-square/merkle v0.0.0-20240117232118-fd78256df076
github.com/celestiaorg/go-square/v2 v2.1.0
Expand Down
6 changes: 4 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,8 +355,10 @@ github.com/celestiaorg/cosmos-sdk v1.25.0-sdk-v0.46.16 h1:f+fTe7GGk0/qgdzyqB8kk8
github.com/celestiaorg/cosmos-sdk v1.25.0-sdk-v0.46.16/go.mod h1:07Z8HJqS8Rw4XlZ+ok3D3NM/X/in8mvcGLvl0Zb5wrA=
github.com/celestiaorg/go-fraud v0.2.1 h1:oYhxI0gM/EpGRgbVQdRI/LSlqyT65g/WhQGSVGfx09w=
github.com/celestiaorg/go-fraud v0.2.1/go.mod h1:lNY1i4K6kUeeE60Z2VK8WXd+qXb8KRzfBhvwPkK6aUc=
github.com/celestiaorg/go-header v0.6.3 h1:VI+fsNxFLeUS7cNn0LgHP6Db66uslnKp/fgMg5nxqHg=
github.com/celestiaorg/go-header v0.6.3/go.mod h1:Az4S4NxMOJ1eAzOaF8u5AZt5UzsSzg92uqpdXS3yOZE=
github.com/celestiaorg/go-header v0.6.3-0.20241205160207-ef9365bd2c70 h1:WSojcu+ZSMwxO+m0TLrGV3UH4kNgeF6QfvyLi0yqO6M=
github.com/celestiaorg/go-header v0.6.3-0.20241205160207-ef9365bd2c70/go.mod h1:Az4S4NxMOJ1eAzOaF8u5AZt5UzsSzg92uqpdXS3yOZE=
github.com/celestiaorg/go-header v0.6.3-0.20250122141912-eb13b856d1f3 h1:UAplgt9MbnEesfz3bodW+W1nqyuRkfADS1AT0E6XS64=
github.com/celestiaorg/go-header v0.6.3-0.20250122141912-eb13b856d1f3/go.mod h1:Az4S4NxMOJ1eAzOaF8u5AZt5UzsSzg92uqpdXS3yOZE=
github.com/celestiaorg/go-libp2p-messenger v0.2.0 h1:/0MuPDcFamQMbw9xTZ73yImqgTO3jHV7wKHvWD/Irao=
github.com/celestiaorg/go-libp2p-messenger v0.2.0/go.mod h1:s9PIhMi7ApOauIsfBcQwbr7m+HBzmVfDIS+QLdgzDSo=
github.com/celestiaorg/go-square v1.1.1 h1:Cy3p8WVspVcyOqHM8BWFuuYPwMitO1pYGe+ImILFZRA=
Expand Down
4 changes: 2 additions & 2 deletions nodebuilder/header/module_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,9 @@ func TestConstructModule_ExchangeParams(t *testing.T) {
)
require.NoError(t, app.Err())
require.Equal(t, exchange.Params.MaxHeadersPerRangeRequest, cfg.Client.MaxHeadersPerRangeRequest)
require.Equal(t, exchange.Params.RangeRequestTimeout, cfg.Client.RangeRequestTimeout)
require.Equal(t, exchange.Params.RequestTimeout, cfg.Client.RequestTimeout)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We changed name of the field in celestiaorg/go-header#194


require.Equal(t, exchangeServer.Params.WriteDeadline, cfg.Server.WriteDeadline)
require.Equal(t, exchangeServer.Params.ReadDeadline, cfg.Server.ReadDeadline)
require.Equal(t, exchangeServer.Params.RangeRequestTimeout, cfg.Server.RangeRequestTimeout)
require.Equal(t, exchangeServer.Params.RequestTimeout, cfg.Server.RequestTimeout)
}
3 changes: 3 additions & 0 deletions nodebuilder/tests/swamp/swamp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,9 @@ func (s *Swamp) DefaultTestConfig(tp node.Type) *nodebuilder.Config {

cfg.Core.IP = ip
cfg.Core.GRPCPort = port

// trigger flushes more often in tests.
cfg.Header.Store.WriteBatchSize = 1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of adding more logic & timeouts in tests it is simpler to force flushes more often.

return cfg
}

Expand Down