fix: `make lint` #13

rootulp · 2024-12-03T20:46:06Z

Closes #12 and then runs lint in CI so we don't have any regressions.
Closes #14

.github/workflows/lint.yml

rootulp · 2024-12-09T03:04:14Z

Ideally we make go test pass before we merge this so that we have more confidence this doesn't introduce any regressions.

ninabarbakadze

utAck

fix: golangci-lint issues

e392c34

rootulp requested a review from ninabarbakadze December 3, 2024 20:46

rootulp self-assigned this Dec 3, 2024

rootulp added 2 commits December 3, 2024 16:06

fix: markdownlint, yamlint, hadolint

6e8998b

ci: run lint in CI

4cbcbab

rootulp commented Dec 3, 2024

View reviewed changes

.github/workflows/lint.yml Outdated Show resolved Hide resolved

rootulp requested a review from cmwaters December 3, 2024 21:11

rootulp changed the title ~~fix: golangci-lint issues~~ fix: make lint issues Dec 3, 2024

rootulp marked this pull request as draft December 10, 2024 19:47

rootulp added 2 commits December 11, 2024 15:36

fix: lint

fee59ce

merge

505f65e

rootulp marked this pull request as ready for review December 11, 2024 20:38

rootulp changed the title ~~fix: make lint issues~~ fix: make lint Dec 11, 2024

rootulp added 4 commits December 11, 2024 15:39

chore: delete changes.md

19791e2

fix: more lint issues

d6aab8a

chore: index with 2 spaces

64bee80

Merge branch 'main' into rp/fix-go-lint

d88d3fd

ninabarbakadze approved these changes Dec 13, 2024

View reviewed changes

rootulp merged commit caa8175 into celestiaorg:main Dec 13, 2024

Provide feedback