Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar & Consistency Fixes in Documentation #1894

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

PixelPil0t1
Copy link
Contributor

@PixelPil0t1 PixelPil0t1 commented Feb 17, 2025

Old: "at little to no costs"
New: "at little to no cost" (uncountable noun)

Old: "are great"
New: "is great" (singular subject)

Old: "Listening for new data commitments"
New: "Listening to new data commitments" (correct collocation)

Old: "steps to setting up"
New: "steps to set up" (correct structure)

Summary by CodeRabbit

  • Documentation
    • Improved grammatical precision and wording in the Community Meetup Guide for enhanced readability.
    • Updated headings, added clarifications, and refined examples in the Blobstream proof queries guide to ensure users follow the latest guidance.
    • Adjusted introductory phrasing in the Celestia bridge node guide for clearer setup instructions.

Copy link
Contributor

coderabbitai bot commented Feb 17, 2025

Walkthrough

This PR introduces updates to several documentation files. Minor grammatical corrections and phrasing adjustments have been applied to improve clarity in the modular meetup guide and the bridge node tutorial. In addition, the Blobstream Proof Queries guide now features an updated heading, refined code snippets with correct contract bindings, and updated method signatures for event handling in respective packages.

Changes

Files Change Summary
community/modular-meetup-guide.md, how-to-guides/bridge-node.md Minor grammatical corrections and phrasing adjustments for improved clarity.
how-to-guides/blobstream-proof-queries.md Updated heading, added clarifications on Blobstream and SP1 Blobstream usage, refined code snippets, and updated method signatures (WatchDataCommitmentStored) to reflect correct event handling.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant AppLibrary as Event Watcher
    participant Contract as Blobstream Contract
    User->>AppLibrary: Subscribe to data commitment events
    AppLibrary->>Contract: Request event subscription (BlobstreamX / SP1 Blobstream)
    Contract-->>AppLibrary: Emit data commitment event
    AppLibrary-->>User: Deliver event data
Loading

Possibly related PRs

Suggested labels

documentation

Suggested reviewers

  • jcstein
  • Ferret-san

Poem

I'm just a little rabbit with a joyful hop,
I nibble on docs where grammar makes a pop.
Corrections and updates dance in every line,
In code and words, everything now aligns.
With a hop and a skip, our docs are simply divine!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0483162 and 7fe05af.

📒 Files selected for processing (3)
  • community/modular-meetup-guide.md (2 hunks)
  • how-to-guides/blobstream-proof-queries.md (1 hunks)
  • how-to-guides/bridge-node.md (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • community/modular-meetup-guide.md
  • how-to-guides/bridge-node.md
🔇 Additional comments (2)
how-to-guides/blobstream-proof-queries.md (2)

1203-1262: Grammar & Consistency Improvement – Updated Heading for Data Commitment Events
The heading now reads "Listening to new data commitments" rather than the previous phrasing. This revision correctly uses the preposition "to" and better reflects standard English usage, thereby enhancing clarity and consistency in the documentation.


1-1577: Overall Documentation Clarity and Consistency Check
This documentation file is highly detailed and well structured. The text, code examples, and inline notes follow a consistent style and formatting throughout. The recent grammatical fixes—such as the update in the heading—improve readability without impacting the technical accuracy of the content.
Consider a final proofreading pass to catch any remaining subtle inconsistencies, but overall the improvements align well with the documentation quality objectives.

🧰 Tools
🪛 LanguageTool

[uncategorized] ~66-~66: If this is a compound adjective that modifies the following noun, use a hyphen.
Context: ...wo are split into shares, which are the low level constructs of a Celestia block, and sav...

(EN_COMPOUND_ADJECTIVE_INTERNAL)


[style] ~75-~75: In American English, abbreviations like “etc.” require a period.
Context: ...are is highlighted in green. R0, R1 etc, represent the respective row and colum...

(ETC_PERIOD)


[uncategorized] ~97-~97: Possible missing comma found.
Context: ...data root tuple root. Check the above diagram which shows: - 0: those are the shares...

(AI_HYDRA_LEO_MISSING_COMMA)


[style] ~110-~110: Consider a shorter alternative to avoid wordiness.
Context: ...lished to the corresponding block. - 3: in order to batch multiple blocks into the same com...

(IN_ORDER_TO_PREMIUM)


[typographical] ~608-~608: The comma may be misplaced. Try moving it before ‘and’, or removing it altogether.
Context: ...tion hash of the PFB containing the blob and, the <blob_index> being the index of t...

(COMMA_AFTER_AND)


[uncategorized] ~778-~778: It seems likely that a singular genitive (’s) apostrophe is missing.
Context: ...(...). ### shareProofs` This is the shares proof to the row roots. These can conta...

(AI_HYDRA_LEO_APOSTROPHE_S_XS)


[uncategorized] ~826-~826: Possible missing comma found.
Context: ...ue The min and max are Namespace type which is: ```solidity /// @notice A re...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~1042-~1042: Loose punctuation mark.
Context: ...leProof proof; } ``` - tupleRootNonce: the nonce at which Blobstream committed...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~1044-~1044: Loose punctuation mark.
Context: ...the block containing the data. - tuple: the DataRootTuple of the block: ```s...

(UNLIKELY_OPENING_PUNCTUATION)


[duplication] ~1061-~1061: Possible typo: you repeated a word.
Context: ..., i.e. the block containing the Rollup data data root, and the heightwhich is thehe...

(ENGLISH_WORD_REPEAT_RULE)


[uncategorized] ~1064-~1064: Loose punctuation mark.
Context: ...s the height of that block. - proof: the BinaryMerkleProof of the data roo...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~1116-~1116: Loose punctuation mark.
Context: ...n during the verification: - dataRoot: can be queried using the `/block?height...

(UNLIKELY_OPENING_PUNCTUATION)


[uncategorized] ~1119-~1119: Loose punctuation mark.
Context: ...ld from the response. - tupleRootNonce: can be retried via querying the data ...

(UNLIKELY_OPENING_PUNCTUATION)

🪛 markdownlint-cli2 (0.17.2)

434-434: Line length
Expected: 80; Actual: 88

(MD013, line-length)


608-608: Line length
Expected: 80; Actual: 87

(MD013, line-length)


610-610: Line length
Expected: 80; Actual: 88

(MD013, line-length)


615-615: Line length
Expected: 80; Actual: 93

(MD013, line-length)


692-692: Line length
Expected: 80; Actual: 99

(MD013, line-length)


696-696: Line length
Expected: 80; Actual: 96

(MD013, line-length)


711-711: Line length
Expected: 80; Actual: 99

(MD013, line-length)


715-715: Line length
Expected: 80; Actual: 94

(MD013, line-length)


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Member

@jcstein jcstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@jcstein jcstein merged commit ee4ed12 into celestiaorg:main Feb 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants