Better handle SP1 errors #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuke-web3
force-pushed
the
n/handle_program_errors
branch
from
b303b4c to
5e7f22f
Compare
nuke-web3
commented
Feb 5, 2025
Comment on lines
+581
to
+584
| // TODO: We cannot clone KeccakInclusionToDataRootProofInput thus we cannot insert into a JobStatus::DataAvalibile(proof_input) | ||
| // So we just redo the work from scratch for the DA side as a stupid workaround | ||
| job_status = | ||
| JobStatus::Failed(e.clone(), Some(JobStatus::DataAvailabilityPending.into())); |
There was a problem hiding this comment.
Not great. Interally to that type,there is a hasher that isn't Copy/Clone we likely can't get (at least directly.
Thinking of other ways that don't need a clone here 🤔
nuke-web3
commented
Feb 6, 2025
Comment on lines
-642
to
+701
| data_base | ||
| .insert( | ||
| job_key, | ||
| bincode::serialize(&update_status) | ||
| .map_err(|e| InclusionServiceError::GeneralError(e.to_string()))?, | ||
| ) | ||
| .map_err(|e| InclusionServiceError::GeneralError(e.to_string()))?; | ||
| (&self.queue_db, &self.finished_db) | ||
| .transaction(|(queue_tx, finished_tx)| { | ||
| finished_tx.remove(job_key.clone())?; | ||
| queue_tx.insert( | ||
| job_key.clone(), | ||
| bincode::serialize(&update_status) | ||
| .expect("Always given serializable job status"), | ||
| )?; | ||
| Ok::<(), sled::transaction::ConflictableTransactionError<InclusionServiceError>>(()) | ||
| }) | ||
| .map_err(|e| InclusionServiceError::InternalError(e.to_string()))?; |
There was a problem hiding this comment.
unrelated fix to ensure we always have jobs finished OR in queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36 (at least in part)