Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Election tests migration #10871

Merged
merged 28 commits into from
Mar 5, 2024
Merged

Election tests migration #10871

merged 28 commits into from
Mar 5, 2024

Conversation

pahor167
Copy link
Contributor

@pahor167 pahor167 commented Jan 8, 2024 •
edited by martinvol
Loading

Description

Migration of Election ts tests to Foundry

closes #10858

@pahor167 pahor167 requested a review from a team as a code owner January 8, 2024 16:45
soloseng
soloseng reviewed Jan 24, 2024
View reviewed changes
Copy link
Contributor

@soloseng soloseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was a really nested test!

Nice work!

packages/protocol/test-sol/voting/Election.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/voting/Election.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/voting/Election.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/voting/Election.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/voting/Election.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/voting/Election.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/voting/Election.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/voting/Election.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/voting/Election.t.sol Outdated Show resolved Hide resolved
packages/protocol/test-sol/voting/Election.t.sol Show resolved Hide resolved
pahor167 and others added 16 commits January 30, 2024 11:06
@pahor167 @soloseng
Update packages/protocol/test-sol/voting/Election.t.sol
f7126da 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/voting/Election.t.sol
574d3a6 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/voting/Election.t.sol
4d19543 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/voting/Election.t.sol
665a862 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/voting/Election.t.sol
957df6b 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/voting/Election.t.sol
97d70a8 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/voting/Election.t.sol
2ec7d46 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/voting/Election.t.sol
a52f6e3 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/voting/Election.t.sol
fdd46bc 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/voting/Election.t.sol
0c3731e 
Co-authored-by: soloseng <[email protected]>
@pahor167 @soloseng
Update packages/protocol/test-sol/voting/Election.t.sol
00b6449 
Co-authored-by: soloseng <[email protected]>
@pahor167
buildable
bf64d49
@pahor167
PR comments 2
bf81648
@pahor167
Missing tests added
b5cabfa
@pahor167
Split of the tests
0fd8221
@pahor167
Merge branch 'master' into pahor/ElectionFoundry
5335a23
@openzeppelin-code OpenZeppelin Code
Copy link

Election tests migration

Generated at commit: d46b82358fe65f5d07f4926dc9340068422754ed

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
3
0
15
39
59
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@pahor167 pahor167 merged commit 4a35759 into master Mar 5, 2024
26 checks passed
@pahor167 pahor167 deleted the pahor/ElectionFoundry branch March 5, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soloseng soloseng soloseng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test/governance/voting/election.ts
2 participants
@pahor167 @soloseng