Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soloseng/Natspec_and_cleanup #11248

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

soloseng
Copy link
Contributor

Description

clean up and add missing natspec

Other changes

Added a requirement to score. manager to prevent accidentally setting score to 100%.

Tested

unit tested

Related issues

@soloseng soloseng requested a review from a team as a code owner October 15, 2024 21:02
packages/protocol/contracts-0.8/common/EpochManager.sol Outdated Show resolved Hide resolved
packages/protocol/contracts-0.8/common/EpochManager.sol Outdated Show resolved Hide resolved
packages/protocol/contracts-0.8/common/IsL2Check.sol Outdated Show resolved Hide resolved
packages/protocol/contracts-0.8/common/IsL2Check.sol Outdated Show resolved Hide resolved
packages/protocol/contracts-0.8/common/IsL2Check.sol Outdated Show resolved Hide resolved
packages/protocol/contracts/common/Blockable.sol Outdated Show resolved Hide resolved
packages/protocol/contracts/common/Blockable.sol Outdated Show resolved Hide resolved
packages/protocol/contracts/common/Blockable.sol Outdated Show resolved Hide resolved
packages/protocol/contracts/common/Blockable.sol Outdated Show resolved Hide resolved
packages/protocol/contracts/common/Blockable.sol Outdated Show resolved Hide resolved
Copy link
Contributor

@m-chrzan m-chrzan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two more comments/suggestions

packages/protocol/contracts-0.8/common/EpochManager.sol Outdated Show resolved Hide resolved
packages/protocol/contracts-0.8/common/ScoreManager.sol Outdated Show resolved Hide resolved
@soloseng soloseng enabled auto-merge (squash) October 16, 2024 14:30
@soloseng soloseng merged commit b2329a3 into release/core-contracts/12 Oct 16, 2024
40 of 42 checks passed
@soloseng soloseng deleted the soloseng/Natspec_and_cleanup branch October 16, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants