Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeeHandler fix #11261

Conversation

martinvol
Copy link
Contributor

@martinvol martinvol commented Oct 25, 2024

  • Allows distributions without burn.
  • Enables burn fraction to be zero

@martinvol martinvol changed the title WIP FeeHandler fix Oct 30, 2024
@@ -1,6 +1,8 @@
// SPDX-License-Identifier: LGPL-3.0-only
pragma solidity ^0.5.13;

import { console } from "forge-std/console.sol";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove console import ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups

@martinvol martinvol marked this pull request as ready for review October 30, 2024 14:56
@martinvol martinvol requested a review from a team as a code owner October 30, 2024 14:56
…ub.com:celo-org/celo-monorepo into martinvol/allowFeeHandlerDistributeWithoutBurn
@martinvol martinvol enabled auto-merge (squash) October 31, 2024 14:04
@martinvol martinvol merged commit 03d20ee into release/core-contracts/12 Oct 31, 2024
40 of 42 checks passed
@martinvol martinvol deleted the martinvol/allowFeeHandlerDistributeWithoutBurn branch October 31, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants