-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FeeHandler fix #11261
Merged
martinvol
merged 12 commits into
release/core-contracts/12
from
martinvol/allowFeeHandlerDistributeWithoutBurn
Oct 31, 2024
Merged
FeeHandler fix #11261
martinvol
merged 12 commits into
release/core-contracts/12
from
martinvol/allowFeeHandlerDistributeWithoutBurn
Oct 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
martinvol
commented
Oct 25, 2024
•
edited
Loading
edited
- Allows distributions without burn.
- Enables burn fraction to be zero
pahor167
reviewed
Oct 30, 2024
@@ -1,6 +1,8 @@ | |||
// SPDX-License-Identifier: LGPL-3.0-only | |||
pragma solidity ^0.5.13; | |||
|
|||
import { console } from "forge-std/console.sol"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove console import ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ups
pahor167
reviewed
Oct 30, 2024
pahor167
reviewed
Oct 30, 2024
pahor167
reviewed
Oct 30, 2024
…erDistributeWithoutBurn
pahor167
approved these changes
Oct 30, 2024
…ub.com:celo-org/celo-monorepo into martinvol/allowFeeHandlerDistributeWithoutBurn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.