Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing uppgrading branch #2861

Open
wants to merge 10 commits into
base: upgrading
Choose a base branch
from
Open

Conversation

dexterhenry
Copy link
Collaborator

Adding initial tests for data_types

@dexterhenry dexterhenry changed the base branch from master to upgrading August 2, 2021 13:16
@dexterhenry dexterhenry closed this Aug 2, 2021
@dexterhenry dexterhenry reopened this Aug 2, 2021
@sanchojaf sanchojaf requested a review from macarci August 6, 2021 14:29
@@ -18,14 +18,128 @@ def create_user(data)

# Confirm captcha token
post api_v3_setup_user_path, params: {
token: captcha_token.token,
code: captcha_token.code
token: captcha_token.token,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dexterhenry why an extra space here

end
end
end
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review in your editor and check if have an option to add empty line to a file

end
end
end

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the last lines

require 'rails_helper'
RSpec.describe Api::V3::ApiController, type: :request do

end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants