feat: adds transitive sharing of peer information #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
force-pushed
the
feat/peer-recon-ring
branch
2 times, most recently
from
5b74e9d to
9e8d80e
Compare
nathanielc
temporarily deployed
to
dev-qa-2024
GitHub Actions
Inactive
nathanielc
force-pushed
the
feat/pairwise-peer-sync
branch
from
a9931a3 to
285bc5f
Compare
nathanielc
commented
Nov 26, 2024
| assert!(is_bi_connected(&test_runner_a, &test_runner_b).await?); | ||
| assert!(is_bi_connected(&test_runner_b, &test_runner_c).await?); | ||
| // We expect that a and c find each other through b and become connected | ||
| assert!(is_bi_connected(&test_runner_a, &test_runner_c).await?); |
There was a problem hiding this comment.
This is the key test, it shows peers can find each other transitively and connect.
nathanielc
temporarily deployed
to
dev-qa-2024
GitHub Actions
Inactive
nathanielc
force-pushed
the
feat/peer-recon-ring
branch
from
4892678 to
d9cdbec
Compare
nathanielc
force-pushed
the
feat/pairwise-peer-sync
branch
from
285bc5f to
2d040d1
Compare
nathanielc
temporarily deployed
to
dev-qa-2024
GitHub Actions
Inactive
nathanielc
requested review from
stbrody and
dav1do
and removed request for
a team
nathanielc
force-pushed
the
feat/pairwise-peer-sync
branch
from
2d040d1 to
baea692
Compare
nathanielc
temporarily deployed
to
dev-qa-2024
GitHub Actions
Inactive
nathanielc
force-pushed
the
feat/pairwise-peer-sync
branch
from
817ebc7 to
baea692
Compare
dav1do
approved these changes
Dec 6, 2024
nathanielc
had a problem deploying
to
dev-qa-2024
GitHub Actions
Failure
nathanielc
temporarily deployed
to
dev-qa-2024
GitHub Actions
Inactive
nathanielc
temporarily deployed
to
dev-qa-2024
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This PR failed the merge queue due to a test I wrote. Looked at it to see if there was potential flaky behavior and I don't see any. It's been passing and I can't reproduce so I'm a bit confused.. somehow the last event wasn't ordering in the failure. Submitted it again to see if it fails again. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change all the pieces are in place such that peers can discover peers from connected peers and connect to those peers.
Fixes: #605
Fixes: #606