chore: use explicit os versions #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This week github updated the `ubuntu-latest` tag to be ubuntu-24.04. This meant that version 0.47.0 of ceramic-one no longer runs on ubuntu-22. This is unexpected and not in our control. With this change we explicitly name the os versions we target (this matters because of glibc versions). This means we will need to add new versions and deprecate old versions as they are released.
nathanielc
temporarily deployed
to
dev-qa-2024
GitHub Actions
Inactive
smrz2001
reviewed
Dec 19, 2024
Comment on lines
+79
to
+86
| name: ceramic-one_${{ matrix.target }}-${{ matrix.os }} | ||
| path: ceramic-one_${{ matrix.target }}-${{ matrix.os }}.bin.tar.gz | ||
| - name: Archive Debian Package | ||
| uses: actions/upload-artifact@v3 | ||
| if: ${{ matrix.ext == 'deb' }} | ||
| with: | ||
| name: ceramic-one_${{ matrix.target }} | ||
| path: ceramic-one_${{ matrix.target }}.tar.gz | ||
| name: ceramic-one_${{ matrix.target }}-${{ matrix.os }} | ||
| path: ceramic-one_${{ matrix.target }}-${{ matrix.os }}.tar.gz |
There was a problem hiding this comment.
We'll also need to use the new OS suffix in ci-scripts/package.sh when preparing the archive, and in .github/workflows/update-homebrew.yml when retrieving the archive SHA.
There was a problem hiding this comment.
Actually, wait, let me check that again.
There was a problem hiding this comment.
Yes, I think we'll need to update the other two files since the specific OS version is now also part of the archive name.
There was a problem hiding this comment.
As well as this js-ceramic file.
nathanielc
temporarily deployed
to
dev-qa-2024
GitHub Actions
Inactive
This was referenced Dec 20, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This week github updated the
ubuntu-latesttag to be ubuntu-24.04. This meant that version 0.47.0 of ceramic-one no longer runs on ubuntu-22. This is unexpected and not in our control. With this change we explicitly name the os versions we target (this matters because of glibc versions). This means we will need to add new versions and deprecate old versions as they are released.