Skip to content

Commit

Permalink
Remove global npm install
Browse files Browse the repository at this point in the history
- Installing globally doesn't work with how the daemon start is currently implemented. Rather than fix that, prefer a local install.
We don't need a global install. The test app brings its own node_modules folders and scripts to run ceramic/composedb, and this makes it easier to compare multiple versions.
  • Loading branch information
dav1do committed Dec 20, 2023
1 parent d6bdd31 commit dd64e4b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion cli/src/install/ceramic_daemon.rs
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ pub async fn install_ceramic_daemon(
if let Some(v) = version.as_ref() {
program.push_str(&format!("@{}", v.to_string()));
}
npm_install_package(&working_directory, &program, true).await?;
npm_install_package(&working_directory, &program, false).await?;

let ans = match start_ceramic {
Some(true) => true,
Expand Down
2 changes: 1 addition & 1 deletion cli/src/install/compose_db.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ pub async fn install_compose_db(
if let Some(v) = version.as_ref() {
program.push_str(&format!("@{}", v.to_string()));
}
npm_install_package(working_directory, &program, true).await?;
npm_install_package(working_directory, &program, false).await?;

let env_file = working_directory.join("composedb.env");
let mut f = tokio::fs::OpenOptions::new()
Expand Down

0 comments on commit dd64e4b

Please sign in to comment.