[+] Added Makefile + Checking script for Go version #222
Conversation
In order to compile vulnapi, you need Go version go1.23.xx. Default installation version for Ubuntu is 1.18.1. Using Makefile, you can now check for go version when compiling. You can also run "make" in order to build, and "make clean" in order to clean. This is a more common way to build.
Not required to build / run vulnapi
There was a problem hiding this comment.
Thanks for your contributions and very sorry for the delay to give you feedback about this PR.
I agree that using a Makefile can be good thing, particularly for more complex projects to build or for someone not familiar with the language build toolchain.
This project is currently quite straightforward to build (thanks to Go for that). Introducing this Makefile adds a specific build process and introduces Ruby and shell dependencies.
Maybe I'm missing the primary purpose of this PR. What issue are you aiming to solve? Did you encounter any issue while building the project?
| @@ -0,0 +1,22 @@ | |||
| FROM ubuntu:22.04 | |||
There was a problem hiding this comment.
There is already a Dockerfile here: https://github.com/cerberauth/vulnapi/tree/main/.docker
Why would be the purpose for this new Dockerfile?
There was a problem hiding this comment.
I though having a "global" Dockerfile, aimed at "contained build and run" could be usefull, but you're absolutely right, there is no need for another Dockerfile.
|
I did not encounter particular issue regarding the build (except issues with the go version, thanks to the Ubuntu Repositories). The idea behind the PR was to add the standard Makefile build tool, in order to have a straightforward way to build, and prevent other people from having the same "issue" with go version. That said, the issue probably lies in the fact that I am not particularly familiar with Go. |
|
Hello @I-S-Tech, I understand now the main purpose of the PR, but I think it is more of a Go installation issue. I am not comfortable maintaining a dedicated Go installation inside the project for different OS, distributions, etc. IMHO This should be more the main purpose of the Go project itself. I am considering adding a contributing documentation with more details about how to starting contributing, including pointing to the right resources for Go installation. I have just opened #236 to add some ideas about this. Feel free to add your ideas. |
These commits add :
In order to compile in a more "usual" way: running
makewill check for dependencies and build the project.Require Ruby in order to check the Go version.
Notes:
makeonly works on linux.