Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Update scatter graph tests to use Jest #326

Merged
merged 6 commits into from
Jan 10, 2024
Merged

Conversation

sdadn
Copy link
Contributor

@sdadn sdadn commented Jan 10, 2024

Summary

This PR continues the work started in #324 to utilize Jest for unit tests instead of Karma.

This PR makes the following changes:

  • Update Scatter graph tests to work with Jest.

Note: A small subset of tests are failing due to differing values or due to an undefined value in the graph API. These tests are being skipped for now as they require dedicated debugging and the current objective is to switch over to Jest for unit tests. These failing tests will be fixed in a separate Jira.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-9813


Thank you for contributing to Terra.
@cerner/terra

@sdadn sdadn self-assigned this Jan 10, 2024
@github-actions github-actions bot temporarily deployed to preview-pr-326 January 10, 2024 17:24 Destroyed
Copy link
Contributor

@adoroshk adoroshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected:
Screenshot 2024-01-10 at 12 32 01 PM

@sdadn sdadn merged commit e778263 into main Jan 10, 2024
10 checks passed
@sdadn sdadn deleted the update-scatter-tests-to-jest branch January 10, 2024 19:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants