Skip to content
This repository has been archived by the owner on May 24, 2024. It is now read-only.

Fix inconsistent ticks rotation for X-axis with calibration enabled #330

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

sugan2416
Copy link
Contributor

Summary

What was changed:

Fixes inconsistent ticks rotation for X-axis with calibration enabled.

Why it was changed:

Some of the tick values of x-axis were rotated when allowCalibration is set to true.

Testing

This change was tested using:

  • WDIO
  • Jest
  • Visual testing (please attach a screenshot or recording)
  • Other (please describe below)
  • No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

  • UX review
  • Accessibility review
  • Functional review

Additional Details

This PR resolves:

UXPLATFORM-10241


Thank you for contributing to Terra.
@cerner/terra

Screenshot 2024-03-28 at 7 27 52 PM

@sdadn
Copy link
Contributor

sdadn commented Mar 28, 2024

Does the tickLabelsRotation work with panning?

@github-actions github-actions bot temporarily deployed to preview-pr-330 March 29, 2024 04:54 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-330 March 29, 2024 07:05 Destroyed
@sugan2416
Copy link
Contributor Author

Does the tickLabelsRotation work with panning?

Yes. Updated to allow rotation with panning in afecbda
Updated example to include panning: fd70d19

@saket2403 saket2403 merged commit 60b0aa8 into main Apr 1, 2024
10 checks passed
@saket2403 saket2403 deleted the graph-ticks-fix branch April 1, 2024 05:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants