Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameterize helm chart variables at post-install-job #3

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

natigavriel
Copy link
Contributor

Hello @cezarguimaraes ,
I would like to use your chart as a dependency to my project.
I needed to inject several parameters (i.e : imagePullSecrets, backoffLimit) to the seeddb job template so it would fit my project.
To my understanding this small change add 2 more generic configuration so it an be useful to all stakeholders as well.

Can you please consider merging this change ?

Best Regards :-)

Copy link
Owner

@cezarguimaraes cezarguimaraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution @natigavriel !

@cezarguimaraes cezarguimaraes merged commit 45b8ab3 into cezarguimaraes:main Feb 6, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants