Skip to content

keep showing progress bar when percent value is/beyond 100 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

keep showing progress bar when percent value is/beyond 100 #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
201d6ba
keep showing progress bar when percent value is/beyond 100
srsajjad Jul 24, 2019
dc9732b
add new prop `showProgressOnHundred`
srsajjad Jul 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ color | string | rainbow | keyword, hexadecimal, rgb, or hsla
percent | number | 0 | 0-100
height | number | 2 | pixels
hideDelay | number | .4 | seconds
showProgressOnHundred | boolean | falsy | seconds
speed | number | .4 | seconds
style | object | {} |

Expand Down
16 changes: 9 additions & 7 deletions src/react-progress.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,15 @@ export default (props) => {
...props
};

let containerStyle = {
opacity: props.percent < 100 ? 1 : 0,
WebkitTransition: `${props.speed}s opacity`,
transition: `${props.speed}s opacity`,
WebkitTransitionDelay: `${props.percent < 100 ? 0 : props.hideDelay}s`,
transitionDelay: `${props.percent < 100 ? 0 : props.hideDelay}s`
};
let containerStyle = props.showProgressOnHundred
? {}
: {
opacity: props.percent < 100 ? 1 : 0,
WebkitTransition: `${props.speed}s opacity`,
transition: `${props.speed}s opacity`,
WebkitTransitionDelay: `${props.percent < 100 ? 0 : props.hideDelay}s`,
transitionDelay: `${props.percent < 100 ? 0 : props.hideDelay}s`
};

let barStyle = {
display: 'inline-block',
Expand Down