Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #351, Fix #355 - Preserve legacy external storage #354

Merged
merged 2 commits into from
Jan 8, 2022

Conversation

Lineflyer
Copy link
Member

Description

Set the flag to preserve the legacy external storage to at least help users, who upgrade the app.

Note:
On new installations this has no effect. Need scoped storage to re-enable file access

Related issues

#351
Related to #309

Additional context

@Lineflyer
Copy link
Member Author

Seems we need to raise the compileSDK to 30 as well to make it build.

@eddiemuc or others:
Any idea whether this could lead to behavior changes?

@Lineflyer Lineflyer added the Do not merge / WIP Not for merging and/or work still in progress label Jan 8, 2022
@Lineflyer Lineflyer changed the title Fix #351 - Preserve legacy external storage Fix #351, #355 - Preserve legacy external storage Jan 8, 2022
@Lineflyer Lineflyer changed the title Fix #351, #355 - Preserve legacy external storage Fix #351, Fix #355 - Preserve legacy external storage Jan 8, 2022
@eddiemuc
Copy link
Member

eddiemuc commented Jan 8, 2022

Seems we need to raise the compileSDK to 30 as well to make it build.

@eddiemuc or others: Any idea whether this could lead to behavior changes?

since the preserve-flag only has an effect if compileSDK is 30, the coupling to compilation makes sense :-)

I only ever dealt with SAF, I guess it is clear how this affects the app (you described it correctly in this PRs text). I don't know what else got introduced with SDK 30.

@eddiemuc
Copy link
Member

eddiemuc commented Jan 8, 2022

For the effects on WhereYouGo see my comment on #351. I would advise NOT to put out a release of WhereYouGo with SDk30/perserve=true unless it already contains migration to SAF

@Lineflyer
Copy link
Member Author

I would advise NOT to put out a release of WhereYouGo with SDk30/perserve=true unless it already contains migration to SAF

But if we put a version out without preserve flag while on target API=30 the file access will be gone anyway and not being able to migrate things even if we set the flag lateron... Or am I missing something here?

@eddiemuc
Copy link
Member

eddiemuc commented Jan 8, 2022

I would advise NOT to put out a release of WhereYouGo with SDk30/perserve=true unless it already contains migration to SAF

But if we put a version out without preserve flag while on target API=30 the file access will be gone anyway and not being able to migrate things even if we set the flag lateron... Or am I missing something here?

That's true. Hm. I guess we don't have a chance then

@Lineflyer
Copy link
Member Author

That's true. Hm. I guess we don't have a chance then

There is no big migration needed for WhereYouGo... it only reads/writes cartridges and reads maps.
As long as new users stick to default folders cartridge reading/writing is no problem, mapfile though do not work.

But thats the best we can do right now without letting users wait rather long (and non functional on Android 12 due to GPS problem).

@Lineflyer Lineflyer merged commit 9740c5d into cgeo:master Jan 8, 2022
@Lineflyer Lineflyer deleted the issue_351 branch January 8, 2022 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do not merge / WIP Not for merging and/or work still in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants