Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #357 Locus integration not working #358

Closed
wants to merge 2 commits into from
Closed

fix #357 Locus integration not working #358

wants to merge 2 commits into from

Conversation

sk-juroot
Copy link
Contributor

fixes #357

Description

  • bump Locus API library on Gradle from 0.2.7 to 0.9.45
  • removed Location initializer with string (no longer supported)
  • changed LAPI dependencies in files to newer version + required refactor of corresponding code
  • changed Location inits with only TAG string resource (obsolete)
  • changed Location.Accuracy (removed support) to horizontal accuracy
  • removed dependency on locus api when loading cartridges (never fully implemented)

Related issues

Additional context

  • this PR is in Do not merge / WIP state until fully tested
  • tried this fix with only one cartridge (with Locus 4 Gold @ Android 11), will do more testing of this change when outside
  • more tests with other Locus versions recommended

@sk-juroot
fix #357 Locus integration not working
828a713 
- bump Locus API library on Gradle from 0.2.7 to 0.9.45
- removed `Location` initializer with string (no longer supported)
- changed LAPI dependencies in files to newer version + required refactor of corresponding code
- changed `Location.java` inits with only `TAG` string resource (obsolete)
- changed `Location.Accuracy` (removed support) to horizontal accuracy
- removed dependency on locus api when loading cartridges (never fully implemented)
@sk-juroot sk-juroot added the Do not merge / WIP Not for merging and/or work still in progress label Jan 9, 2022
@sk-juroot sk-juroot added the dependencies Pull requests that update a dependency file label Jan 9, 2022
bekuno
bekuno reviewed Jan 9, 2022
View reviewed changes
build.gradle
@@ -103,7 +103,7 @@ dependencies {

// Locus Maps integration
//noinspection GradleDependency
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should now delete L105 //noinspection GradleDependency

bekuno
bekuno reviewed Jan 9, 2022
View reviewed changes
src/main/java/menion/android/whereyougo/gui/activity/MainActivity.java
@@ -49,7 +49,8 @@
import cz.matejcik.openwig.Engine;
import cz.matejcik.openwig.formats.CartridgeFile;
import locus.api.objects.extra.Location;
import locus.api.objects.extra.Waypoint;

//import locus.api.objects.extra.Waypoint;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From history:
locus.api.objects.extra.Waypoint was refactored to locus.api.objects.extra.Point, then integrated in locus.api.objects.geoData.Point.

@bekuno
Copy link
Member

bekuno commented Jan 9, 2022

  • changed Location.Accuracy (removed support) to horizontal accuracy

I am fine if we stay in this way. Maybe it is better to implement an own self calculated Location.Accuracy.

@bekuno
Copy link
Member

bekuno commented Jan 10, 2022

  • changed Location.Accuracy (removed support) to horizontal accuracy

I am fine if we stay in this way. Maybe it is better to implement an own self calculated Location.Accuracy.

I have to correct me.
My mistake was that I confused vertical = height with North-South direction.
So there is no need for a setAccuracyVer .

@bekuno bekuno mentioned this pull request Jan 23, 2022
Closed
@bekuno
Copy link
Member

bekuno commented Feb 22, 2023

@sk-juroot
Are you interested to finish your work?
If you can do it the next days, then we should wait for it before creating the next release.

@moving-bits
Copy link
Member

@sk-juroot Are you interested to finish your work? If you can do it the next days, then we should wait for it before creating the next release.

Too late for that, release got published already because of urgent adaption to website changes, but creating a second release in a short time would not be a problem.

@Dratenik
Copy link
Contributor

Hi, what's the status, please? I'm concerned about a broken integration with Locus Classic. If you're interested, I've solved the update locus api lib in ref_357_upgrade_locusapi. It is also possible to create a PR if there is interest. Cheers.

@bekuno
Copy link
Member

bekuno commented Feb 24, 2023

Hi, what's the status, please? I'm concerned about a broken integration with Locus Classic. If you're interested, I've solved the update locus api lib in ref_357_upgrade_locusapi. It is also possible to create a PR if there is interest. Cheers.

@Dratenik
We are very grateful for any help.
I have checked your branch. The change looks very good. Please create a PR.

@bekuno
Copy link
Member

bekuno commented Feb 26, 2023

@sk-juroot Many thanks for your initial work.
Closing here, this PR is now replaced by #426.

@bekuno bekuno closed this Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bekuno bekuno bekuno left review comments

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file Do not merge / WIP Not for merging and/or work still in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration with Locus no longer working
4 participants
@sk-juroot @bekuno @moving-bits @Dratenik