feat(otgfs): Implement OTG_FS USB Driver #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ideally this should address some of the concern in #40 as this will now provide a USB_FS example in |
|
Looks like there is a few things failing because some metapac updates aren't done correctly yet. Let me address those soon and get this in a clean state. |
|
Test should pass once ch32-rs/ch32-data#9 is merged and I will update the dependency commit hash. |
The primary purpose of this change is to introduce an initial implementation of the USB OTG FS device driver. Although this should also applie to other SKUs that have the USB FS (without OTG) but those are currently untested due to the lack of said hardware for testing. In the process of implementing support for USB, we noticed that the WFI instruction in the Qingke IP has significant flaws causing the USB peripheral unable to access memory correctly while the CPU is under WFI. The exact reason behind this is unclear, but a workaround has been put inplace by using a new executor we added to embassy named `arch-spin` which avoids the use of WFI instruction altogether. Also there were several updates to the peripheral access crate (PAC) to ensure the USB driver code is as readable as possible. The update may have not been applied to all device families, especially those using USB_FS instead of having the full OTG peripheral. The code has been tested on CH32V307 and CH32V305 with the following applications: - USB DFU: mostly to exercise usb control transfer - USB HID: mostly to exercise usb interrupt transfer We will also provide a simple USB DFU example in the `examples/ch32v307` directory for those who want to just quickly verify any functionalities. Co-authored-by: Dummyc0m <[email protected]> Co-authored-by: Codetector <[email protected]>
Looks like there will be more features than chip families so looks like it would make more sense to have the table be transposed so on a normal monitor it would be easier to read.
This patch removes the defmt feature from ch32-hal in the example. - Using defmt requires that special linker script setup, and it is not present - I also don't believe that these simple examples should depend on defmt anyways, especially that we can't do defmt over rtt currently.
|
Cool now everything should be fixed :) perfect |
andelf
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary purpose of this change is to introduce an initial
implementation of the USB OTG FS device driver. Although this should
also applie to other SKUs that have the USB FS (without OTG) but those
are currently untested due to the lack of said hardware for testing.
In the process of implementing support for USB, we noticed that the WFI
instruction in the Qingke IP has significant flaws causing the USB
peripheral unable to access memory correctly while the CPU is under WFI.
The exact reason behind this is unclear, but a workaround has been put
inplace by using a new executor we added to embassy named
arch-spinwhich avoids the use of WFI instruction altogether.
Also there were several updates to the peripheral access crate (PAC) to
ensure the USB driver code is as readable as possible. The update may
have not been applied to all device families, especially those using
USB_FS instead of having the full OTG peripheral.
The code has been tested on CH32V307 and CH32V305 with the following
applications:
We also provided a simple USB DFU example in the
examples/ch32v307directory for those who want to just quickly verify any functionalities.