Skip to content

Atari100k, DER, and OTRainbow #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Atari100k, DER, and OTRainbow #286

wants to merge 1 commit into from

Conversation

alirahkay
Copy link
Collaborator

No description provided.

@alirahkay alirahkay requested review from dapatil211 and a team May 24, 2022 20:10
@alirahkay alirahkay changed the base branch from main to dev May 24, 2022 20:10
@alirahkay
Copy link
Collaborator Author

alirahkay commented May 24, 2022 •
edited
Loading

I just have not yet gotten the results for the OTRainbow.
Please review the PR, but don't merge it until I make the results ready.

@dapatil211 dapatil211 requested a review from TongTongX May 25, 2022 16:45
@alirahkay
Copy link
Collaborator Author

alirahkay commented Jun 3, 2022 •
edited
Loading

Based on my experiments (26 games all 5 seeds), we have:

DER
DER baseline, mean: 0.28543676671224993, median: 0.16136157795467734
DER RLHive, mean: 0.29438721585036576, median: 0.1904422041798461

OTRainbow
OTRainbow baseline, mean: 0.26407827599681083, median: 0.2036846538468431
OTRainbow RLHive, mean: 0.2385813492674032, median: 0.1378254499932332

TongTongX
TongTongX reviewed Jun 17, 2022
View reviewed changes
@alirahkay alirahkay requested a review from TongTongX June 27, 2022 20:19
@dapatil211
Copy link
Collaborator

I think this may have been a problem with how terminal states were being handled before. Should be fixed now? Could you try rerunning with latest code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapatil211 dapatil211 Awaiting requested review from dapatil211

@TongTongX TongTongX Awaiting requested review from TongTongX

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alirahkay @dapatil211 @TongTongX