Skip to content

Small tweaks in the setup #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

Small tweaks in the setup #28

merged 1 commit into from
May 2, 2025

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented May 2, 2025

No description provided.

@Andarist Andarist requested a review from s0 May 2, 2025 09:25
Copy link
Collaborator

@s0 s0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, 1 comment / question

@@ -1,2 +1 @@
provenance=true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for disabling provenance and removing the ID token?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id-token - I don't udnerstand it 😂 I tried to google it up quickly but I couldn't find what exactly it does for us here.

provenance - I wasn't quite sure if this would work, doesn't it require some extra setup? I recall people complaining that Changesets doesn't support it yet. I haven't had a chance to look into it though. I just went for the simplest setup possible, reflecting the one that we have in other repos. But certainly if we can make this work - it would be great to make it work but perhaps in follow up PRs?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure happy to do it in follow up PRs. It should "just work" in theory, with the id token set up. Can test it here and then if it works apply it elsewhere =)

@Andarist Andarist enabled auto-merge (squash) May 2, 2025 10:47
@Andarist Andarist disabled auto-merge May 2, 2025 10:47
@Andarist Andarist merged commit 47e9fa1 into main May 2, 2025
4 checks passed
@Andarist Andarist deleted the small-tweaks branch May 2, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants