Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor codequality improvements #44

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Minor codequality improvements #44

wants to merge 4 commits into from
+51 −10

Conversation

ciriousjoker
Copy link
Contributor

@ciriousjoker ciriousjoker commented Jan 22, 2023 •
edited
Loading

  • Private Chargebee() constructor
  • configure() now takes named args
  • Added toString() to Product & PurchaseResult

If this is merged, remember to update the minor version of this package, since this is a breaking change before v1.0.0. I'm assuming this package adheres to SemVer.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ciriousjoker