Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Retain forward slashes in Chargebee IDs #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ArneZsng
Copy link

@ArneZsng ArneZsng commented Nov 15, 2023

Description

Fix: Retain forward slashes in Chargebee IDs

If the Chargebee ID contains a forward slash ("/"), this should not be URL escaped in the query as Chargebee will not be able to interpret it. Thus, we retain any forward slashes in IDs when querying the API.

When querying, this does not work:

curl  https://acme.chargebee.com/api/v2/subscriptions/ACME%20GmbH%2FCompany%20GmbH/renewal_estimate

This works, however:

curl  https://acme.chargebee.com/api/v2/subscriptions/ACME%20GmbH/Company%20GmbH/renewal_estimate

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant