fix: label arrays to be delimited by comma and add spaces for line charts #12086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not 100% sure that #12049 is a bug. @LeeLenaleee thoughts? |
|
I agree that it is not visually the most pleasing, but I don't think this is the correct fix. |
|
@LeeLenaleee Do you mean we'd want to modify the ', ' to an '\n' or is it something else altogether? Also, does the title text need to be centered?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12049
Line controllers apparently didn't have an overridden implementation for DatasetController's getLabelAndValue method.
Kept it within the line controller to not affect anything else.