Skip to content

cfg: added cargo/config; add +nightly #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Conversation

Horki
Copy link
Contributor

@Horki Horki commented Nov 1, 2020

@chemicstry
Added +nightly to cargo build

  • separate config for flags

@chemicstry
Copy link
Owner

I was thinking of using .cargo/config.toml like this, but then decided not to, because you can't specify build-std just for one target. All targets are forced to recompile std this way.

It would work if it was just for wasm_thread examples, but build_wasm.sh is more of an example how to build other projects using this library. I don't think there is a workaround for this until wasm atomics are stabilized in rust rust-lang/rust#77839

@Horki
Copy link
Contributor Author

Horki commented Nov 2, 2020

@chemicstry Ok, seems to make sense;

  • still I have updated branch to add +nigthly on build script, so it can ran on other default toolchain

@chemicstry chemicstry merged commit ff2b05c into chemicstry:main Nov 2, 2020
@Horki Horki deleted the cfg_fix branch November 2, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants