Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Perm Alloc & Used Max to Summary #201

Merged
merged 1 commit into from
Aug 1, 2018

Conversation

amcrn
Copy link
Contributor

@amcrn amcrn commented Jul 20, 2018

Adds totalPermAllocMax, totalPermUsedMax, and
totalPermUsedMaxpc to the Summary output.

Example:

totalPermAllocMax; 512; M
totalPermUsedMax; 103.398; M
totalPermUsedMaxpc; 20.2; %

@codecov-io
Copy link

codecov-io commented Jul 20, 2018

Codecov Report

Merging #201 into develop will increase coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #201      +/-   ##
=============================================
+ Coverage      69.39%   69.64%   +0.24%     
- Complexity      1467     1471       +4     
=============================================
  Files            145      145              
  Lines           8366     8375       +9     
  Branches        1368     1369       +1     
=============================================
+ Hits            5806     5833      +27     
+ Misses          1981     1964      -17     
+ Partials         579      578       -1
Impacted Files Coverage Δ Complexity Δ
...raum/perf/gcviewer/exp/impl/SummaryDataWriter.java 84.8% <100%> (+6.85%) 29 <0> (+3) ⬆️
...va/com/tagtraum/perf/gcviewer/view/GCDocument.java 34.93% <0%> (+0.96%) 23% <0%> (ø) ⬇️
.../com/tagtraum/perf/gcviewer/util/MemoryFormat.java 88.88% <0%> (+4.76%) 12% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7db04c2...06b2df7. Read the comment docs.

@amcrn
Copy link
Contributor Author

amcrn commented Jul 20, 2018

@chewiebug I don't see an easy way to avoid this 0.09% decrease in coverage by amending a test, but please give me a pointer if you believe otherwise. Thanks!

@chewiebug
Copy link
Owner

I have added a unittest for SummaryDataWriter (see "develop" branch). It should be easy to add another test to check your additions.

@amcrn amcrn force-pushed the enh/perm-summary branch 2 times, most recently from f3b328c to d707e17 Compare July 31, 2018 19:23
@amcrn
Copy link
Contributor Author

amcrn commented Jul 31, 2018

@chewiebug Thanks for the baseline SummaryDataWriterTest, that definitely helped. I added a Test and the coverage is green now :)

@amcrn amcrn force-pushed the enh/perm-summary branch from d707e17 to c2fd9e5 Compare July 31, 2018 21:34
totalPermUsedMaxpc to the Summary output.

Example:

    totalPermAllocMax; 512; M
    totalPermUsedMax; 103.398; M
    totalPermUsedMaxpc; 20.2; %
@amcrn amcrn force-pushed the enh/perm-summary branch from c2fd9e5 to 06b2df7 Compare August 1, 2018 00:10
@chewiebug chewiebug merged commit 06b2df7 into chewiebug:develop Aug 1, 2018
@chewiebug
Copy link
Owner

chewiebug commented Aug 1, 2018 via email

@chewiebug chewiebug added this to the 1.36 milestone Aug 1, 2018
@amcrn amcrn deleted the enh/perm-summary branch August 1, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants