some work towards memoizing selectors... much more to do here.

chilli-axe · Dec 29, 2024 · 9d83f45 · 9d83f45
1 parent 0096aaf
commit 9d83f45
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/frontend/src/features/bulkManagement/bulkManagementRibbon.tsx b/frontend/src/features/bulkManagement/bulkManagementRibbon.tsx
@@ -26,7 +26,7 @@ import {
   clearQueries,
   deleteSlots,
   selectAllSelectedProjectMembersHaveTheSameQuery,
-  selectAllSlotsForFace,
+  selectAllSlotsForActiveFace,
   selectIsProjectEmpty,
   selectProjectMember,
   selectSelectedSlots,
@@ -109,8 +109,7 @@ function SelectSimilar({
 function SelectAll({ inDropdown }: { inDropdown: boolean }) {
   const dispatch = useAppDispatch();
 
-  const face = useAppSelector(selectActiveFace);
-  const slots = useAppSelector((state) => selectAllSlotsForFace(state, face));
+  const slots = useAppSelector(selectAllSlotsForActiveFace);
   const onClick = () =>
     dispatch(bulkSetMemberSelection({ selectedStatus: true, slots: slots }));
 

diff --git a/frontend/src/features/project/projectSlice.ts b/frontend/src/features/project/projectSlice.ts
@@ -17,6 +17,7 @@ import {
   Slots,
 } from "@/common/types";
 import { selectCardSizesByIdentifier } from "@/features/search/cardDocumentsSlice";
+import { selectActiveFace } from "@/features/viewSettings/viewSettingsSlice";
 
 //# region slice configuration
 
@@ -309,11 +310,12 @@ export const selectProjectMemberIdentifiers = createSelector(
     )
 );
 
-export const selectAllSlotsForFace = (
-  state: RootState,
-  face: Faces
-): Array<[Faces, number]> =>
-  state.project.members.map((_, index) => [face, index]);
+export const selectAllSlotsForActiveFace = createSelector(
+  (state: RootState) => selectProjectSize(state),
+  (state: RootState) => selectActiveFace(state),
+  (projectSize, face): Array<[Faces, number]> =>
+    Array.from({ length: projectSize }, (_, index) => [face, index])
+);
 
 export const selectSelectedSlots = createSelector(
   (state: RootState) => state.project.members,
@@ -440,7 +442,7 @@ export const selectAllSelectedProjectMembersHaveTheSameQuery = createSelector(
 );
 
 export const selectIsProjectEmpty = (state: RootState) =>
-  state.project.members.length == 0;
+  selectProjectSize(state) == 0;
 
 export const selectProjectCardback = (state: RootState): string | undefined =>
   state.project.cardback ?? undefined;