Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and Upgrade Patreon Support #210

Merged
merged 14 commits into from
Jan 28, 2024
Merged

Conversation

Investigamer
Copy link
Contributor

Description

Patreon Fixes

  • Handle paginated results
  • Exclude Patreon's automatic 'Free' tier
  • Exclude non-active patrons
  • Ensure display patron tier reflects their highest backed tier
  • Enforce sorting patrons by tier level (dollar amount)

Minor Fixes

  • Update Levenshtein in reqs and pre-commit-config for Python 3.12 support
  • Exclude common virtual environment names from mypy tests

Pre-Commit Notes

Right now pre-commit on my end is falsely asserting that the module elasticsearch has no attribute Elasticsearch (MPCAutofill\cardpicker\search\search_functions.py line 9) so I had to force commit overriding the pre-commit hook, all other pre-commit checks passed.

Checklist

  • I have installed pre-commit and run the hooks with pre-commit run.
  • I have updated any related tests for code I modified or added new tests where appropriate.
  • I have updated any relevant documentation or created new documentation where appropriate.

Copy link
Collaborator

@ndepaola ndepaola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just a couple of minor comments

btw you can get the tests on github actions passing if you add your google drive api key as a repo secret - iirc there are instructions in the wiki

@@ -53,7 +53,7 @@ repos:
"django-widget-tweaks~=1.4.12",
"google-api-python-client~=2.86",
"jsonschema~=4.20.0",
"Levenshtein~=0.21.1",
"Levenshtein~=0.23.0",
Copy link
Collaborator

@ndepaola ndepaola Jan 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidianstyle fyi - this resolves the python 3.12 issues you encountered the other day https://github.com/rapidfuzz/Levenshtein/releases/tag/v0.22.0

MPCAutofill/cardpicker/integrations/patreon.py Outdated Show resolved Hide resolved
MPCAutofill/requirements.txt Show resolved Hide resolved
MPCAutofill/cardpicker/integrations/patreon.py Outdated Show resolved Hide resolved
MPCAutofill/cardpicker/integrations/patreon.py Outdated Show resolved Hide resolved
@ndepaola ndepaola added the bug Something isn't working label Jan 28, 2024
@ndepaola ndepaola merged commit 3d28561 into chilli-axe:master Jan 28, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

2 participants