-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix and Upgrade Patreon Support #210
Conversation
attempt to public beta link fix, part 2
Bring into line with master repo
Bring into line with master repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! just a couple of minor comments
btw you can get the tests on github actions passing if you add your google drive api key as a repo secret - iirc there are instructions in the wiki
@@ -53,7 +53,7 @@ repos: | |||
"django-widget-tweaks~=1.4.12", | |||
"google-api-python-client~=2.86", | |||
"jsonschema~=4.20.0", | |||
"Levenshtein~=0.21.1", | |||
"Levenshtein~=0.23.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davidianstyle fyi - this resolves the python 3.12 issues you encountered the other day https://github.com/rapidfuzz/Levenshtein/releases/tag/v0.22.0
Co-authored-by: Nicholas de Paola <[email protected]>
Co-authored-by: Nicholas de Paola <[email protected]>
Signed-off-by: Investigamer <[email protected]>
…data may be missing Signed-off-by: Investigamer <[email protected]>
Signed-off-by: Investigamer <[email protected]>
Description
Patreon Fixes
Minor Fixes
Pre-Commit Notes
Right now pre-commit on my end is falsely asserting that the module
elasticsearch
has no attributeElasticsearch
(MPCAutofill\cardpicker\search\search_functions.py
line 9) so I had to force commit overriding the pre-commit hook, all other pre-commit checks passed.Checklist
pre-commit
and run the hooks withpre-commit run
.