-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow processing multiple projects in desktop tool #219
Merged
ndepaola
merged 13 commits into
master
from
allow-processing-multiple-projects-in-desktop-tool
Apr 25, 2024
Merged
Allow processing multiple projects in desktop tool #219
ndepaola
merged 13 commits into
master
from
allow-processing-multiple-projects-in-desktop-tool
Apr 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
298dc37
to
bbd2f0e
Compare
this is a bit more verbose but it's the necessary groundwork for reusing an autofill driver for multiple card orders
this refactor will simplify our order combination logic
[wip] a quick sketch of order combining. will flesh this out later. bit late here (11:39pm) and i have work tomorrow continued sketching of order combining & splitting parking this again at 11:13pm continue with order combination it seems like it's now customary to note i'm writing this at 10:33pm
this involves removing --skipsetup as a CLI flag and reinstating it as a question the tool asks the user for each order it's processing.
and fleshed out tests a bit
this refactor makes it easier to reason about our data and will help when we look at merging the slots of multiple cards
...slots of identical cards across combined projects this refactor allows for an enhancement to image collection combination - we can now handle the case where an image is present in both collections by taking the union of their slots. for example, say you combine two projects which share the same cardback - after this change, the tool will continue to recognise it as a single cardback, so it'll choose "same images" and fill the cardback into one slot; previously, it would have treated the cardbacks of each project as distinct, then would have chosen "different cardbacks" which is way slower and much more painful. bit painful to update all these tests like this to be honest! but i'm in utter shock that they all passed on the first try :0000
8d76ab6
to
4fdcee0
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
pre-commit
and installed the hooks withpre-commit install
before creating any commits.